Fix static libs INTERFACE_INCLUDE_DIRECTORIES #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
vrabaud
approved these changes
Nov 14, 2024
|
Thx ! |
vrabaud
reviewed
Nov 14, 2024
WangWeiLin-MV
force-pushed
the
cmake/merge_static_libs/copy-include-dirs
branch
from
d12cde0
to
281a6d7
Compare
|
@WangWeiLin-MV , does that new version of the patch actually fix the original bug ? |
|
@vrabaud Yes, in my tests, it was generated correctly in add_library(avif STATIC IMPORTED)
set_target_properties(avif PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
)and invoke |
|
Great, thx ! |
wantehchang
reviewed
Nov 15, 2024
| @@ -52,6 +52,11 @@ function(merge_static_libs target in_target) | |||
| set(source_file ${CMAKE_CURRENT_BINARY_DIR}/${target}_depends.c) | |||
| add_library(${target} STATIC ${source_file}) | |||
|
|
|||
| get_target_property(include_dirs ${in_target} INTERFACE_INCLUDE_DIRECTORIES) | |||
| if(include_dirs) | |||
| target_include_directories(${target} PUBLIC ${include_dirs}) | |||
There was a problem hiding this comment.
Hi @WangWeiLin-MV,
INTERFACE seems more appropriate than PUBLIC because ${include_dirs} comes from the INTERFACE_INCLUDE_DIRECTORIES property of ${in_target}.
Could you see if INTERFACE also works? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue microsoft/vcpkg#42112, error with
fatal error: 'avif/avif.h' file not foundthat targetavif(i.e.avif_static) lostINTERFACE_INCLUDE_DIRECTORIESfor static build.Let
merge_static_libs.cmakecopyINTERFACE_INCLUDE_DIRECTORIEStoo.