Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bail out of avifDecoderParse() if an essential-required item property is not flagged as essential #537
base: main
Are you sure you want to change the base?
Bail out of avifDecoderParse() if an essential-required item property is not flagged as essential #537
Changes from 1 commit
6e37228
9e1d828
2d0a644
69057a7
a26c941
e166009
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if
a1op
needs to be handled differently here.Also, should there be an opposite check for
a1lx
since the spec says "If associated, it shall not be marked as essential"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I'm thinking about removing
lsel
from the list for now and just adding boxes to this list as I add support for new boxes.lsel
isn't written or read at all right now, so it seems odd to preemptively block a read on it.