Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description fixes #318

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sean-fitzpatrick
Copy link
Collaborator

Quality control fixes to images in Section 1.1. More to come for other sections, so keep open for now.

@sean-fitzpatrick
Copy link
Collaborator Author

@Alex-Jordan I've done a first pass through the descriptions in Chapter 1.

I'll work on getting the HTML rebuilt ASAP. If these look all right to you, I can merge, and look over later chapters when I have more time.

@Alex-Jordan
Copy link
Collaborator

Thanks Sean! I haven't reviewed your descriptions, but I'm sure they are good and I wouldn't quibble.

Removing firstcurvestyle seems like it will have unwanted side effects. Just off the top of my head, any function where the graph needs to be drawn with two components, and the components are drawn using these open, openclosed, etc. styles. Two components means you don't want to use addplot+ for them. But if you are using open, etc, you've lost the stuff like firstcolor that is set in firstcurvestyle.

@sean-fitzpatrick
Copy link
Collaborator Author

I ran a global search on each of those styles. In almost all cases where they are used with addplot and not addplot+, firstcurvestyle was specified (e.g. as addplot [firstcurvestyle, openclosed]). In the few cases where this wasn't the case, I added it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants