Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve DOM-less type exports #352

Merged
merged 1 commit into from
Jun 3, 2024
Merged

chore: Improve DOM-less type exports #352

merged 1 commit into from
Jun 3, 2024

Commits on Jun 3, 2024

  1. chore: Improve DOM-less type exports 

    Usage of HeadersInit requires either a node-fetch dependency or to
include DOM in tsconfig libs for consumer projects. It is not exported
as a global type in @types/node v18 or v20. RequestInit is:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/aaf94a0a6431f52c46dab26182f1156d79720d29/types/node/v18/globals.d.ts#L341

Define headers in interface HTTPResolverOptions<> via
RequestInit['headers'] which will make it possible to depend on this
project without node-fetch.
    @mdmower-csnw
    mdmower-csnw committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    96f90df View commit details
    Browse the repository at this point in the history