Fix N reallocation/retranslocation issue in SimpleLeaf

[BrianCollinss]

Resolves #8714

Also in Soybean (#8714 (comment)) and Sorghum (#8714 (comment))

There might be a problem in the way Reallocation is calculated. However, based on what there is in the Leaf class, I removed two checks/tests from SimpleLeaf and added one single check similar to the one that exists in the Leaf class.

[hol353]

@hut104 Can you have a look at this one?

[BrianCollinss]

Hey @hut104. Eagerly looking forward to your comments! :)

[par456]

Could you explain why those tests aren't necessary with your changes? It might help us understand what your changes do. You said you changed SimpleLeaf and Leaf, but only one file was included in this PR.

Also, at the moment you've commented out those lines, if the idea is to remove them, can you just fully delete them from the code.

[BrianCollinss]

These two tests do not exist in the Leaf class. I uploaded some simulations where these tests failed. So, either these tests should not be used (as per in the Leaf class) or something is wrong in calculating N reallocation in SimpleLeaf. I removed the troublesome tests and replaced them with a single test from the Leaf class.

[BrianCollinss]

This one is either a very simple fix or a sign of a major issue. In either case, I will be happy to close it if not of interest.

[par456]

We aren't sure of that ourselves. The person we need to have a look at this has been busy lately so we haven't been able to determine what action to take.

It would be good to leave this open a bit longer until they can check it, because if it is an error, we do want to have it fixed.

[BrianCollinss]

A friendly reminder of this.

[BrianCollinss]

Hey @par456 . This has been here for four months now. Any chance someone with a better grasp of internal processes can have a look? It has been reported in three crops so far.