Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Soil Temperature model #9197

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hol353
Copy link
Contributor

@hol353 hol353 commented Jul 29, 2024

Resolves #4080

@hol353
Copy link
Contributor Author

hol353 commented Nov 12, 2024

Todo:

  • Check all indexing in all arrays. Looks wrong in some places.
  • Unit test failing: SimulationResetTests.
  • Put node diagram into documentation:
    SoilTemperature.pptx
  • Various tests are failing on Jenkins with error:

Please check your soil physical node. The rock content, bulk density and/or saturated water content are inconsistent with each other. You will need to fix your soil properties before proceeding. Note that if you have rocks in the soil, the bulk density is on a fine earth basis (g fine earth/cc whole soil volume)

ERROR in file: ./Prototypes/SCRUM/FARWheat/SCRUMFAR.apsimx
Simulation name: PRyegrassNLevel5
Simulation name: PRyegrassNLevel4
Simulation name: PRyegrassNLevel1
Simulation name: PRyegrassNLevel2
Simulation name: PRyegrassNLevel6
Simulation name: PRyegrassNLevel3

ERROR in file: ./Prototypes/SCRUM/SCRUM.apsimx
Simulation name: HawkesBayRot3_N2_Irr1
Simulation name: HawkesBayRot3_N1_Irr1
Simulation name: HawkesBayRot3_N3_Irr1
Simulation name: HawkesBayRot3_N1_Irr2
Simulation name: HawkesBayRot3_N2_Irr2
Simulation name: HawkesBayRot3_N3_Irr2
Simulation name: Lincoln2012NitMedIrrFull
Simulation name: HawkesBayRot3_N4_Irr1
Simulation name: ABlockRotPW_W1_N0
Simulation name: HawkesBayRot3_N4_Irr2
Simulation name: Lincoln2012NitLowIrrFull
Simulation name: ABlockRotPW_W2_N0

ERROR in file: ./Prototypes/SCRUM/SCRUM.apsimx
Simulation name: Lincoln2012NitNilIrrFull
Simulation name: LincolnRot1_N4_Irr1
Simulation name: LincolnRot1_N1_Irr1
Simulation name: ABlockRotPP_W2_N0
Simulation name: LincolnRot1_N3_Irr1
Simulation name: ABlockRotPP_W1_N2
Simulation name: ABlockRotPP_W2_N2
Simulation name: ABlockRotPP_W1_N0
Simulation name: ABlockRotPW_W2_N1
Simulation name: ABlockRotPW_W1_N2
Simulation name: ABlockRotPW_W2_N2
Simulation name: ABlockRotPP_W1_N1
Simulation name: ABlockRotPP_W2_N1
Simulation name: LincolnRot1_N2_Irr2
Simulation name: LincolnRot1_N2_Irr1
Simulation name: LincolnRot1_N4_Irr2
Simulation name: HawkesBayRot4_N4_Irr2
Simulation name: LincolnRot1_N1_Irr2
Simulation name: HawkesBayRot4_N3_Irr2
Simulation name: LincolnRot1_N3_Irr2
Simulation name: HawkesBayRot4_N2_Irr1
Simulation name: HawkesBayRot4_N1_Irr1
Simulation name: HawkesBayRot4_N1_Irr2
Simulation name: HawkesBayRot4_N3_Irr1
Simulation name: ABlockRotPW_W1_N1
Simulation name: HawkesBayRot4_N4_Irr1
Simulation name: HawkesBayRot4_N2_Irr2
Simulation name: LincolnRot2_N1_Irr1
Simulation name: LincolnRot2_N4_Irr2
Simulation name: LincolnRot2_N2_Irr1
Simulation name: LincolnRot2_N4_Irr1
Simulation name: LincolnRot2_N1_Irr2
Simulation name: LincolnRot2_N2_Irr2
Simulation name: LincolnRot2_N3_Irr1
Simulation name: LincolnRot2_N3_Irr2

ERROR in file: ./Tests/Validation/Oats/Oats.apsimx
Simulation name: TempletonLysimeter2017SowAug
Simulation name: SAE_Oats_2020CultivarsFallow
Simulation name: TempletonLysimeter2017SowJul
Simulation name: WinterSowing2017Rate300
Simulation name: WinterSowing2017Rate0
Simulation name: SLMACC_Southland_2021Rate0
Simulation name: SLMACC_Southland_2021Rate150
Simulation name: SLMACC_Southland_2021Rate300
Simulation name: SLMACC_Southland_2021Rate450
Simulation name: SLMACC_WestCoast1_2020Rate300
Simulation name: SLMACC_WestCoast1_2020Rate0
Simulation name: SLMACC_Canterbury_2021Rate0

ERROR in file: ./Tests/Validation/Eucalyptus/Eucalyptus.apsimx
Simulation name: WestfieldT1N0
Simulation name: WestfieldT2N950
Simulation name: WestfieldT3N300
Simulation name: WestfieldT4N600
Simulation name: WestfieldT5N2000
Simulation name: WestfieldT6N1200

ERROR in file: ./Tests/Validation/RedClover/RedClover.apsimx
Simulation name: IversenIrrigationFull
Simulation name: IversenIrrigationNil

ERROR in file: ./Tests/Validation/Chicory/Chicory.apsimx
Simulation name: IversenIrrigationFull

ERROR in file: ./Tests/Validation/System/FACTS_CornSoy/FACTS_McNay.apsimx
Simulation name: McNaySystem26
Simulation name: McNaySystem25
Simulation name: McNaySystem27b
Simulation name: McNaySystem25b
Simulation name: McNaySystem27
Simulation name: McNaySystem28

ERROR in file: ./Tests/Validation/System/FACTS_CornSoy/FACTS_Kanawha.apsimx
Simulation name: KanawahaSystem24
Simulation name: KanawahaSystem23b

ERROR in file: ./Tests/Validation/Peanut/Peanut.apsimx
Simulation name: Kingaroy1819CvRedvaleIrrigationWet
Simulation name: Kingaroy1819CvTaabingaIrrigationWet

ERROR in file: ./Tests/Validation/Wheat/Wheat.apsimx
Simulation name: FAR WAA W20-01aMgmtHigh InputCvCutlass
Simulation name: FAR WAA W20-01aMgmtStandardCvIllabo
Simulation name: FAR WAA W20-01bMgmtStandardCvCutlass
Simulation name: FAR WAA W20-01aMgmtStandardCvScepter
Simulation name: FAR WAA W20-01aMgmtStandardCvCutlass
Simulation name: FAR WAA W20-01aMgmtGrazedCvCutlass
Simulation name: FAR WAA W20-01bMgmtStandardCvScepter
Simulation name: FAR WAA W20-01aMgmtGrazedCvIllabo
Simulation name: FAR WAA W20-01aMgmtHigh InputCvScepter
Simulation name: FAR WAA W20-01aMgmtHigh InputCvIllabo
Simulation name: FAR WAA W20-01bMgmtGrazedCvCutlass
Simulation name: FAR WAA W20-01aMgmtGrazedCvScepter
Simulation name: FAR WAA W20-01bMgmtGrazedCvIllabo
Simulation name: FAR WAA W20-01bMgmtGrazedCvScepter
Simulation name: FAR WAA W20-01bMgmtStandardCvIllabo
Simulation name: FAR WAA W20-01bMgmtHigh InputCvCutlass
Simulation name: FAR WAA W20-01bMgmtHigh InputCvIllabo
Simulation name: FAR WAE W22-02MgmtGrazedCvBeaufort
Simulation name: FAR WAE W22-02MgmtStandardCvIllabo
Simulation name: FAR WAA W20-01bMgmtHigh InputCvScepter
Simulation name: FAR WAE W22-02MgmtStandardCvBeaufort
Simulation name: FAR WAE W22-02MgmtHigh InputCvIllabo
Simulation name: FAR WAE W22-02MgmtHigh InputCvBeaufort
Simulation name: FAR WAE W22-02MgmtHigh InputCvScepter
Simulation name: FAR WAE W22-02MgmtStandardCvScepter
Simulation name: FAR WAE W22-02MgmtGrazedCvScepter
Simulation name: FAR WAE W22-02MgmtGrazedCvIllabo

ERROR in file: ./Tests/Validation/Barley/Barley.apsimx
Simulation name: CPTCultBossSD2004-05-28
Simulation name: CPTCultDoyenSD2004-05-28
Simulation name: CPTCultCellarSD2004-05-28
Simulation name: CPTCultCountySD2004-05-28
Simulation name: CPTCultOpticSD2004-05-28
Simulation name: CPTCultSherwoodSD2004-05-28
Simulation name: CPTCultOmakaSD2004-05-28
Simulation name: CPTCultVortexSD2004-05-28
Simulation name: CPTCultTavernSD2004-05-28
Simulation name: CPTCultDashSD2004-05-28
Simulation name: CPTCultPyramidSD2004-05-28
Simulation name: CPTCultCountySD2006-05-10
Simulation name: CPTCultCellarSD2006-05-10
Simulation name: CPTCultOmakaSD2006-05-10
Simulation name: CPTCultDoyenSD2006-05-10
Simulation name: CPTCultVortexSD2006-05-10
Simulation name: CPTCultBossSD2006-05-10
Simulation name: CPTCultOpticSD2006-05-10
Simulation name: CPTCultDashSD2006-05-10
Simulation name: CPTCultTavernSD2006-05-10
Simulation name: CPTCultSherwoodSD2006-05-10
Simulation name: CPTCultPyramidSD2006-05-10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port the old apsim SoilTemp2 model
1 participant