Skip to content

Commit

Permalink
Add note about regex and schema version to contributing.md
Browse files Browse the repository at this point in the history
  • Loading branch information
CitadelStationBot authored and CitadelStationBot committed Aug 26, 2017
1 parent d2c89ad commit 7cd8cde
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,8 @@ This prevents nesting levels from getting deeper then they need to be.

* All changes to the database's layout(schema) must be specified in the database changelog in SQL, as well as reflected in the schema files

* Any time the schema is changed the `schema_revision` table and `DB_MAJOR_VERSION` or `DB_MINOR_VERSION` defines must be incremented.

* Queries must never specify the database, be it in code, or in text files in the repo.


Expand All @@ -246,6 +248,8 @@ This prevents nesting levels from getting deeper then they need to be.

* Do not divide when you can easily convert it to multiplication. (ie `4/2` should be done as `4*0.5`)

* If you used regex to replace code during development of your code, post the regex in your PR for the benefit of future developers and downstream users.

#### Enforced not enforced
The following coding styles are not only not enforced at all, but are generally frowned upon to change for little to no reason:

Expand Down

0 comments on commit 7cd8cde

Please sign in to comment.