-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update NEXRAD location data using latest NCEI database #1595
base: main
Are you sure you want to change the base?
Conversation
…tically loaded station information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few linting errors - once these are fixed, we should be good to go!
@mgrover1 Do we need any other changes except for the linting issues? For example, raising an error? |
@gewitterblitz I just found this PR while needing to find out the NEXRAD locations. And I noticed that you should use
|
Thanks for the heads up @ghiggi Yes, I realized that the Regarding From what I have heard, the ROC testbeds have variable identifiers and are not meant for operational purposes. It may be better to add their geolocation manually while analyzing data and perhaps that's why the PyART team decided to not include those here. Happy to be corrected though! |
This is correct from my understanding as well!
Agreed - we should refrain from storing those shorter term locations as that could be dangerous in terms of analysis; users can specify that on their own! |
@gewitterblitz - thinking about this more - what happens if the user is using a machine that does not have internet access? Within high-performance computing clusters, this would be common limitation... We should store a copy of the table just in case. Otherwise, one would not be able to read/work with NEXRAD data if they are on a compute cluster without outside internet access... |
@mgrover1 That's a valid point. Is there a way to create (or update) a NEXRAD geolocation look-up table from the NCEI URL every time there's a new PyART release? Perhaps a Github action task? |
This PR takes care of the NEXRAD location discrepancy by pulling the latest information from the NCEI Historical Observing Metadata Repository directly. Interested users/developers can find the latest NEXRAD location database by clicking on the NEXRAD station list file view.