Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NEXRAD location data using latest NCEI database #1595

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gewitterblitz
Copy link

This PR takes care of the NEXRAD location discrepancy by pulling the latest information from the NCEI Historical Observing Metadata Repository directly. Interested users/developers can find the latest NEXRAD location database by clicking on the NEXRAD station list file view.

@gewitterblitz gewitterblitz requested a review from zssherman as a code owner June 4, 2024 21:05
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few linting errors - once these are fixed, we should be good to go!

@gewitterblitz
Copy link
Author

@mgrover1 Do we need any other changes except for the linting issues? For example, raising an error?

@ghiggi
Copy link

ghiggi commented Jan 24, 2025

@gewitterblitz I just found this PR while needing to find out the NEXRAD locations. And I noticed that you should use skiprows=2 instead of skiprows=6, otherwise you don't get the info for the first 4 radars ('KABR', 'KABX', 'KAKQ', 'KAMA' ).
FYI:

  • in the table there is not the info for 'KILM', 'KJAN', 'KRMX', 'KUNR' radars and the ROC testbeds (DAN1, DOP1, FOP1, NOP*, ROP*).
  • elevation is reported in feets although pyart already converts to meters in get_nexrad_location.

@gewitterblitz
Copy link
Author

gewitterblitz commented Jan 29, 2025

Thanks for the heads up @ghiggi
I have updated the pull request. I think the mismatch may have been due to the nexrad location file being updated from NOAA's end. It's a dynamic URL that they can update anytime they wish.

Yes, I realized that the get_nexrad_location function takes care of the unit conversion.

Regarding 'KILM', 'KJAN', 'KRMX', 'KUNR' radars: I don't think these radars are operational anymore. As all of these served for short terms (and went out of service before the dual-pol upgrade), I highly doubt anyone uses their data for research purposes. However, I could be wrong and it may be worthwhile adding their info to the list.

From what I have heard, the ROC testbeds have variable identifiers and are not meant for operational purposes. It may be better to add their geolocation manually while analyzing data and perhaps that's why the PyART team decided to not include those here. Happy to be corrected though!

@mgrover1
Copy link
Collaborator

Regarding 'KILM', 'KJAN', 'KRMX', 'KUNR' radars: I don't think these radars are operational anymore. As all of these served for short terms (and went out of service before the dual-pol upgrade), I highly doubt anyone uses their data for research purposes. However, I could be wrong and it may be worthwhile adding their info to the list.

This is correct from my understanding as well!

From what I have heard, the ROC testbeds have variable identifiers and are not meant for operational purposes. It may be better to add their geolocation manually while analyzing data and perhaps that's why the PyART team decided to not include those here. Happy to be corrected though!

Agreed - we should refrain from storing those shorter term locations as that could be dangerous in terms of analysis; users can specify that on their own!

@mgrover1
Copy link
Collaborator

@gewitterblitz - thinking about this more - what happens if the user is using a machine that does not have internet access? Within high-performance computing clusters, this would be common limitation...

We should store a copy of the table just in case. Otherwise, one would not be able to read/work with NEXRAD data if they are on a compute cluster without outside internet access...

@gewitterblitz
Copy link
Author

@mgrover1 That's a valid point. Is there a way to create (or update) a NEXRAD geolocation look-up table from the NCEI URL every time there's a new PyART release? Perhaps a Github action task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated NEXRAD location database
3 participants