feat: take out hardcoded dimensions and branch from workflow

Signed-off-by: Jeroen Branje <[email protected]>
ASCS-eV · Dec 3, 2024 · 6f245af · 6f245af
1 parent d542ac5
commit 6f245af
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 40 deletions.
diff --git a/.github/workflows/deploy-staging.yml b/.github/workflows/deploy-staging.yml
@@ -3,7 +3,6 @@ on:
   push:
     branches:
       - develop
-      - 336_handle_data_from_asset
   workflow_dispatch:
 
 # Concurrency group name ensures concurrent workflow runs wait for any in-progress job to finish

diff --git a/apps/envited.ascs.digital/common/asset/createTokenMetadata.test.ts b/apps/envited.ascs.digital/common/asset/createTokenMetadata.test.ts
@@ -46,11 +46,6 @@ describe('common/asset/createTokenMetadata', () => {
           {
             uri: 'ipfs://DISPLAY_URI_CID',
             hash: 'DISPLAY_URI_CID',
-            mimeType: 'image/png',
-            dimensions: {
-              value: '1095x850',
-              unit: 'px',
-            },
             fileSize: 512,
             fileName: 'DISPLAY_URI',
           },
@@ -89,8 +84,6 @@ describe('common/asset/createTokenMetadata', () => {
           cid: 'DISPLAY_URI_CID',
           uri: 'DISPLAY_URI',
           fileSize: 512,
-          dimensions: '1095x850',
-          mimeType: 'image/png',
         },
         domainMetadata: {
           cid: 'DOMAIN_METADATA_CID',
@@ -150,11 +143,6 @@ describe('common/asset/createTokenMetadata', () => {
           {
             uri: 'ipfs://DISPLAY_URI_CID',
             hash: 'DISPLAY_URI_CID',
-            mimeType: 'image/png',
-            dimensions: {
-              value: '1095x850',
-              unit: 'px',
-            },
             fileSize: 512,
             fileName: 'DISPLAY_URI',
           },
@@ -193,8 +181,6 @@ describe('common/asset/createTokenMetadata', () => {
           cid: 'DISPLAY_URI_CID',
           uri: 'DISPLAY_URI',
           fileSize: 512,
-          dimensions: '1095x850',
-          mimeType: 'image/png',
         },
         domainMetadata: {
           cid: 'DOMAIN_METADATA_CID',
@@ -254,11 +240,6 @@ describe('common/asset/createTokenMetadata', () => {
           {
             uri: 'ipfs://DISPLAY_URI_CID',
             hash: 'DISPLAY_URI_CID',
-            mimeType: 'image/png',
-            dimensions: {
-              value: '1095x850',
-              unit: 'px',
-            },
             fileSize: 512,
             fileName: 'DISPLAY_URI',
           },
@@ -297,8 +278,6 @@ describe('common/asset/createTokenMetadata', () => {
           cid: 'DISPLAY_URI_CID',
           uri: 'DISPLAY_URI',
           fileSize: 512,
-          dimensions: '1095x850',
-          mimeType: 'image/png',
         },
         domainMetadata: {
           cid: 'DOMAIN_METADATA_CID',
@@ -358,11 +337,6 @@ describe('common/asset/createTokenMetadata', () => {
           {
             uri: 'ipfs://DISPLAY_URI_CID',
             hash: 'DISPLAY_URI_CID',
-            mimeType: 'image/png',
-            dimensions: {
-              value: '1095x850',
-              unit: 'px',
-            },
             fileSize: 512,
             fileName: 'DISPLAY_URI',
           },
@@ -401,8 +375,6 @@ describe('common/asset/createTokenMetadata', () => {
           cid: 'DISPLAY_URI_CID',
           uri: 'DISPLAY_URI',
           fileSize: 512,
-          dimensions: '1095x850',
-          mimeType: 'image/png',
         },
         domainMetadata: {
           cid: 'DOMAIN_METADATA_CID',

diff --git a/apps/envited.ascs.digital/common/asset/createTokenMetadata.ts b/apps/envited.ascs.digital/common/asset/createTokenMetadata.ts
@@ -83,11 +83,6 @@ export const createTokenMetadata = ({
       {
         uri: formatIpfsUri(display.cid),
         hash: display.cid,
-        mimeType: 'image/png',
-        dimensions: {
-          value: '1095x850',
-          unit: 'px',
-        },
         fileSize: display.fileSize,
         fileName: extractFilenameFromPath(display.uri),
       },

diff --git a/apps/envited.ascs.digital/common/asset/validateAndCreateMetadata.test.ts b/apps/envited.ascs.digital/common/asset/validateAndCreateMetadata.test.ts
@@ -13,11 +13,6 @@ describe('common/asset/validateAndCreateMetadata', () => {
       const createMetadataStub = jest.fn().mockReturnValue('METADATA_BUFFER') as any
       const createModifiedManifestStub = jest.fn().mockReturnValue('MODIFIED_MANIFEST_BUFFER') as any
       const createFilenameStub = jest.fn().mockReturnValue('HASH') as any
-      const getImageDimensionsAndTypeStub = jest.fn().mockResolvedValue({
-        width: 1095,
-        height: 850,
-        type: 'image/png',
-      }) as any
       const getAllFilenamesFromFilesStub = jest.fn().mockResolvedValue([
         {
           path: 'PATH',
@@ -74,7 +69,6 @@ describe('common/asset/validateAndCreateMetadata', () => {
         createFilename: createFilenameStub,
         getFilesAsPathAndByteArrayFromManifest: getFilesAsPathAndByteArrayFromManifestStub,
         getAllFilenamesFromFiles: getAllFilenamesFromFilesStub,
-        // getImageDimensionsAndType: getImageDimensionsAndTypeStub,
         db: dbStub,
       })(byteArray as any, asset as any)