Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(envited.ascs.digital): Add Assets dummy pages #131

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

jeroenbranje
Copy link
Contributor

Scope

There should be a assets overview and detail page example

Closes #128 #129

@jeroenbranje jeroenbranje requested a review from royscheeren March 6, 2024 14:30
Copy link
Contributor

@royscheeren royscheeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just have to make sure we dont fall into the trap of fetching asset data inside the components. It has to be fetched in the page.tsx and passed in through props.
Not required for demo pages.

apps/design-system/src/components/Atoms/Button/Button.tsx Outdated Show resolved Hide resolved
apps/envited.ascs.digital/app/assets/detail/page.tsx Outdated Show resolved Hide resolved
apps/envited.ascs.digital/app/assets/page.tsx Outdated Show resolved Hide resolved
apps/envited.ascs.digital/modules/Footer/Footer.tsx Outdated Show resolved Hide resolved
apps/envited.ascs.digital/modules/Header/Header.tsx Outdated Show resolved Hide resolved
apps/envited.ascs.digital/modules/Header/Header.tsx Outdated Show resolved Hide resolved
@jeroenbranje jeroenbranje requested a review from royscheeren March 6, 2024 16:02
@jeroenbranje jeroenbranje merged commit 74bddf1 into develop Mar 7, 2024
1 check passed
@jeroenbranje jeroenbranje deleted the 128_assets_dummy_pages branch March 7, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Assets overview "dummy" page
2 participants