Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credits announcement #424

Merged
merged 26 commits into from
Feb 23, 2024
Merged

Credits announcement #424

merged 26 commits into from
Feb 23, 2024

Conversation

jtherrmann
Copy link
Contributor

@jtherrmann jtherrmann commented Feb 20, 2024 •
edited
Loading

Docs on adding an announcement: https://squidfunk.github.io/mkdocs-material/setup/setting-up-the-header/#announcement-bar

TODO:

  • Figure out how to move the announcement from mkdocs-asf-theme to hyp3-docs
  • Announcement style tweaks mkdocs-asf-theme#60
  • Pin to the latest version of mkdocs-asf-theme
  • Get rid of the extra X button that appears in the announcement bar (does not seem to be clickable, not sure what it is)
  • Changelog entry
  • TODO items in code
  • Add credits page to sidebar menu
  • Link to credits page from quota page

This was referenced Feb 22, 2024
Merged
Merged
jtherrmann
jtherrmann commented Feb 23, 2024
View reviewed changes
docs/credits.md Outdated Show resolved Hide resolved
@jtherrmann jtherrmann marked this pull request as ready for review February 23, 2024 21:28
@jtherrmann jtherrmann requested a review from a team as a code owner February 23, 2024 21:28
@jtherrmann jtherrmann merged commit c7817f9 into develop Feb 23, 2024
5 checks passed
@jtherrmann jtherrmann deleted the credits-announcement branch February 23, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asjohnston-asf asjohnston-asf asjohnston-asf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtherrmann @asjohnston-asf