Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add tests to merge_tops_bursts.py #191

Merged
merged 30 commits into from
Feb 1, 2024
Merged

Conversation

forrestfwilliams
Copy link
Contributor

Add tests for most functions inside of merge_tops_bursts.py. Also includes many refactors that were exposed as needed when testing was implemented.

Notably tests have not been added for the following functions:

  • merge_tops_bursts
  • package_output
  • run_isce2_workflow
  • prepare_products
  • mask_coherence
    The rational here is that these are all "workflow style" functions that mainly group calls to several well-tested functions.

@forrestfwilliams forrestfwilliams requested a review from a team January 31, 2024 19:26
Copy link
Contributor

github-actions bot commented Jan 31, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
/home/runner/micromamba/envs/hyp3-isce2/lib/python3.11/site-packages/hyp3_isce2
   __main__.py26292%33, 44
   burst.py2505578%98–101, 114–119, 133–148, 164–173, 187–197, 255, 303–311, 331–345, 583–585, 611
   dem.py53394%101–110
   insar_stripmap.py694239%38–91, 95–97, 114–133
   insar_tops.py573047%49–87, 110–132
   insar_tops_burst.py22717921%83–155, 167–193, 223–306, 360–362, 375–468, 492–508, 544–628
   logging.py4175%9
   merge_tops_bursts.py6058885%182, 199, 261, 266, 323, 339, 347, 379, 383, 468, 495, 572, 612–630, 679–683, 707, 712, 771, 794, 923, 1060–1080, 1095–1108, 1122–1143, 1154–1159, 1166–1179, 1183
   s1_auxcal.py21290%51, 59
   slc.py341071%22–25, 29–34
   stripmapapp_alos.py50786%102, 138, 141–146
   topsapp.py70889%77, 107, 129–135
   utils.py199697%113–124, 129, 235, 396, 441
   water_mask.py59592%88, 100–103
/home/runner/micromamba/envs/hyp3-isce2/lib/python3.11/site-packages/hyp3_isce2/metadata
   util.py14936%6–14, 18–21, 25–27
TOTAL175044774% 

Tests Skipped Failures Errors Time
84 1 💤 0 ❌ 0 🔥 30.871s ⏱️

@forrestfwilliams forrestfwilliams merged commit 8ed2160 into merge_bursts Feb 1, 2024
3 checks passed
@forrestfwilliams forrestfwilliams deleted the tests2 branch February 1, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants