Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pause function to 2-way scenario #829

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

jackfox25
Copy link
Contributor

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Vizard key listener configured to set pause flag, which skips ExecuteSimulation() call. Keeps vizInterface module updating while paused in order to:

  1. allow broadcast users to connect
  2. listen for the unpause key
  3. process panel responses and keyboard inputs that enact immediately once unpaused

Continually resets clock_sync module to keep Vizard from accelerating to catch up after unpause.
Can press 'z' to cleanly end scenario, even while paused.

Verification

Manual live-stream testing

Documentation

Updated vizardLiveComm page to discuss logic needed to handle pausing

Future work

None

@jackfox25 jackfox25 added the enhancement New feature or request label Oct 9, 2024
@jackfox25 jackfox25 requested a review from a team as a code owner October 9, 2024 16:23
@jackfox25 jackfox25 changed the title Feature/viz2way pause Add pause function to 2-way scenario Oct 9, 2024
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the missing release notes. Otherwise this was good to go. Thanks for the contribution.

@schaubh schaubh merged commit a021e1c into develop Oct 14, 2024
9 checks passed
@schaubh schaubh deleted the feature/viz2way_pause branch October 14, 2024 14:28
@jackfox25 jackfox25 assigned jackfox25 and unassigned schaubh Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants