Skip to content

Commit

Permalink
Merge pull request #555 from Ferusel/tingkai/fix-uml-dg
Browse files Browse the repository at this point in the history
Fix DG UML diagrams
  • Loading branch information
bryanljx authored Nov 7, 2022
2 parents f339d24 + 9804949 commit ab20fbe
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/_dg/implementations/ItemFeatures.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ Here is the activity diagram showing the process of the `edit` command:

![ItemSequenceDiagram](images/EditItemSequenceDiagram.png)

This diagram excludes the instantiation of the objects that represents attributes in an Item, e.g. `ItemQuantity`, `ItemUnit`. This is because including all of them would cause the UML diagram to be cluttered and too small to read.
This diagram excludes the instantiation of the objects that represents attributes in an Item, e.g. `ItemQuantity`, `ItemUnit`, when the `EditCommand` object creates an `editedItem`. This is because including all of them would cause the UML diagram to be cluttered and too small to read.

##### Feature Details

Expand Down
3 changes: 1 addition & 2 deletions docs/diagrams/NewItemActivityDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ if () then ([else])
stop
else ([Storage space for Items is available])
endif
:new command successfully executes.
Item is edited.;
:new command successfully executes.;
stop

@enduml
Expand Down
Binary file modified docs/images/NewItemActivityDiagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit ab20fbe

Please sign in to comment.