Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change r/ and c/ as a way to clear the fields to r/nil and c/nil #186

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Change r/ and c/ as a way to clear the fields to r/nil and c/nil #186

merged 2 commits into from
Apr 12, 2024

Conversation

JuliaPoo
Copy link

Fixes #149, Fixes #185.

@JuliaPoo JuliaPoo added the bug Something isn't working label Apr 11, 2024
@JuliaPoo JuliaPoo added this to the v1.4 milestone Apr 11, 2024
@JuliaPoo JuliaPoo requested a review from a team April 11, 2024 14:43
@JuliaPoo JuliaPoo self-assigned this Apr 11, 2024
@Fidget-Spinner
Copy link

What happens when you pass this as a role to another command? e.g. the charge command?

@JuliaPoo
Copy link
Author

JuliaPoo commented Apr 11, 2024

It errors out with invalid role format, since I added the check within the Role.isValidRoleName thingy

@Fidget-Spinner
Copy link

Ok needs merge conflict fixing/

# Conflicts:
#	src/main/java/seedu/address/logic/parser/EditCommandParser.java
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.06%. Comparing base (8f4e2ad) to head (8a4effe).

Files Patch % Lines
.../seedu/address/logic/parser/EditCommandParser.java 50.00% 0 Missing and 1 partial ⚠️
src/main/java/seedu/address/model/cca/Cca.java 0.00% 0 Missing and 1 partial ⚠️
src/main/java/seedu/address/model/roles/Role.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #186      +/-   ##
============================================
- Coverage     66.15%   66.06%   -0.10%     
- Complexity      553      555       +2     
============================================
  Files            95       95              
  Lines          2163     2163              
  Branches        219      219              
============================================
- Hits           1431     1429       -2     
  Misses          652      652              
- Partials         80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JuliaPoo
Copy link
Author

Okay I did the merge.

@JuliaPoo JuliaPoo merged commit 834a24e into AY2324S2-CS2103T-W11-2:master Apr 12, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currently no way to clear roles and CCAs for a member [PE-D][Tester A] edit cca with only whitespace
2 participants