Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues #188

Merged
merged 3 commits into from
Apr 14, 2024
Merged

Fix multiple issues #188

merged 3 commits into from
Apr 14, 2024

Conversation

JuliaPoo
Copy link

@JuliaPoo JuliaPoo commented Apr 12, 2024

Fixes #187, Fixes #176, Fixes #172, Fixes #144
Fixes #148 (See point 5 below).

  1. Error when charge does nothing.
  2. Error when cca_delete tries to delete a CCA that does not exist.
  3. Correct ChargeCommand.MESSAGE_USAGE.
  4. Correct DeleteCcaCommand.MESSAGE_USAGE.
  5. Added details to FilterCommand.MESSAGE_USAGE.
  6. Correct OweCommand.MESSAGE_USAGE.
  7. Fix parsing for OweCommand where multiple m/ were allowed but not handled.
  8. Fix message for DeleteCcaCommand.
  9. Fix AddCommand.MESSAGE_USAGE
  10. Fix EditCommand.MESSAGE_USAGE
  11. Fix AddCommand parsing multiple m/
  12. Fix EditCommand parsing multiple m/

1. Error when `charge` does nothing.
2. Error when `cca_delete` tries to delete a CCA that does not exist.
3. Correct `ChargeCommand.MESSAGE_USAGE`.
4. Correct `DeleteCcaCommand.MESSAGE_USAGE`.
5. Added details to `FilterCommand.MESSAGE_USAGE`.
6. Correct `OweCommand.MESSAGE_USAGE`.
7. Fix parsing for OweCommand where multiple `m/` were allowed but not handled.
@JuliaPoo JuliaPoo added the bug Something isn't working label Apr 12, 2024
@JuliaPoo JuliaPoo added this to the v1.4 milestone Apr 12, 2024
@JuliaPoo JuliaPoo requested a review from a team April 12, 2024 20:51
@JuliaPoo JuliaPoo self-assigned this Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 65.58%. Comparing base (834a24e) to head (2ce65bc).
Report is 1 commits behind head on master.

Files Patch % Lines
...seedu/address/logic/commands/DeleteCcaCommand.java 0.00% 10 Missing ⚠️
...va/seedu/address/logic/commands/ChargeCommand.java 0.00% 7 Missing ⚠️
...u/address/logic/parser/DeleteCcaCommandParser.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
- Coverage     66.06%   65.58%   -0.49%     
- Complexity      555      556       +1     
============================================
  Files            95       95              
  Lines          2163     2182      +19     
  Branches        219      217       -2     
============================================
+ Hits           1429     1431       +2     
- Misses          652      669      +17     
  Partials         82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JuliaPoo JuliaPoo merged commit df3367f into AY2324S2-CS2103T-W11-2:master Apr 14, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment