Fix Trimming of Excess Whitespace in Name #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
============================================
+ Coverage 65.73% 65.74% +0.01%
- Complexity 555 556 +1
============================================
Files 95 95
Lines 2174 2175 +1
Branches 219 219
============================================
+ Hits 1429 1430 +1
Misses 663 663
Partials 82 82 ☔ View full report in Codecov by Sentry. |
JuliaPoo
requested changes
Apr 13, 2024
| @@ -27,6 +27,10 @@ public class ParserUtil { | |||
|
|
|||
| public static final String MESSAGE_INVALID_INDEX = "Index is not a non-zero unsigned integer."; | |||
|
|
|||
| public static String innerTrim(String string) { | |||
| return String.join(" ", string.split("\\s+")); | |||
There was a problem hiding this comment.
Okay so \s matches more than just spaces, like newlines. But ig we can just say we arent supporting any of the other whitespaces for now so im going to approve this trim.
However, can you edit it to String.join(" ", string.split("\\s+")).trim();? This is to handle when the string is like " uwu"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
Did the same for address, roles, CCAs, and metadata