-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP User Guide #192
WIP User Guide #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, else LGTM.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
=========================================
Coverage 65.73% 65.73%
Complexity 555 555
=========================================
Files 95 95
Lines 2174 2174
Branches 219 219
=========================================
Hits 1429 1429
Misses 663 663
Partials 82 82 ☔ View full report in Codecov by Sentry. |
In addition to fixing checkstyle, I added a broken links detector: by appending the following code at the bottom of the page: <script>
let meow = [...document.getElementsByTagName("a")].filter(a => a.href.includes("#")).filter(a => document.getElementById(a.href.split("#")[1]) === null).map(a => ` -- [${a.textContent}](${a.href.split("#")[1]})`).join("\n");
if (meow !== "") alert(`Broken links:\n${meow}`)
</script> EDIT: OK SO THE ABOVE IS WRONG, SEE #193 |
This pull mostly:
edit
oradd
.The old UG is in the file
UserGuide.md.old
There are still many issues to be fixed. Refer to #83.
Currently the User Guide looks like this. There is still a lot to be done, especially regarding documenting each of the commands to a satisfactory standard.
The absolutely most time consuming thing right now, is to document each command properly. Please refer to
edit
andadd
where I've partially done up the documentation (still missing potential failures section for each), as a reference for documenting other commands.Furthermore, there are still a few missing sections. Refer to the notes in #83. E.g., a section with an explanation of the GUI elements of the UG itself.
Furthermore, there are definitely small things to take note of, such as broken links, and a more informal language.