Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP User Guide #192

Merged
merged 6 commits into from
Apr 13, 2024
Merged

WIP User Guide #192

merged 6 commits into from
Apr 13, 2024

Conversation

JuliaPoo
Copy link

@JuliaPoo JuliaPoo commented Apr 13, 2024

This pull mostly:

  1. Fix factual errors in the UG
  2. Established a format for the documentation of each command
    • E.g., with regards to communicating the format of each command, just modify the LATEX given for edit or add.
  3. Restructured the Features section.

The old UG is in the file UserGuide.md.old

There are still many issues to be fixed. Refer to #83.

Currently the User Guide looks like this. There is still a lot to be done, especially regarding documenting each of the commands to a satisfactory standard.

The absolutely most time consuming thing right now, is to document each command properly. Please refer to edit and add where I've partially done up the documentation (still missing potential failures section for each), as a reference for documenting other commands.

Furthermore, there are still a few missing sections. Refer to the notes in #83. E.g., a section with an explanation of the GUI elements of the UG itself.

Furthermore, there are definitely small things to take note of, such as broken links, and a more informal language.

@JuliaPoo JuliaPoo added the documentation Improvements or additions to documentation label Apr 13, 2024
@JuliaPoo JuliaPoo added this to the v1.4 milestone Apr 13, 2024
@JuliaPoo JuliaPoo requested a review from a team April 13, 2024 14:39
Copy link

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, else LGTM.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.73%. Comparing base (96a3e71) to head (7410ed3).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage     65.73%   65.73%           
  Complexity      555      555           
=========================================
  Files            95       95           
  Lines          2174     2174           
  Branches        219      219           
=========================================
  Hits           1429     1429           
  Misses          663      663           
  Partials         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JuliaPoo
Copy link
Author

JuliaPoo commented Apr 13, 2024

In addition to fixing checkstyle, I added a broken links detector:
image

by appending the following code at the bottom of the page:

<script>
let meow = [...document.getElementsByTagName("a")].filter(a => a.href.includes("#")).filter(a => document.getElementById(a.href.split("#")[1]) === null).map(a => `  -- [${a.textContent}](${a.href.split("#")[1]})`).join("\n");
if (meow !== "") alert(`Broken links:\n${meow}`)
</script>

EDIT: OK SO THE ABOVE IS WRONG, SEE #193

@JuliaPoo JuliaPoo merged commit 7cbcdee into AY2324S2-CS2103T-W11-2:master Apr 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants