Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/phone validator #202

Merged

Conversation

alphajae11
Copy link

Add simple phone validator to ensure that all phone number added or edited must be 8 digit that start with either 8 or 9

close #162

@alphajae11 alphajae11 added the bug Something isn't working label Apr 14, 2024
@alphajae11 alphajae11 added this to the v1.4 milestone Apr 14, 2024
@alphajae11 alphajae11 self-assigned this Apr 14, 2024
Copy link

@chuahjiajie chuahjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alphajae11 alphajae11 merged commit 8129fb0 into AY2324S2-CS2103T-W11-2:master Apr 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester B] Phone numbers may need to be validated
2 participants