Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DeleteCommand tests #122

Merged
merged 11 commits into from
Nov 7, 2024

Conversation

jessica2828
Copy link

Key changes:

  • Added more tests related to delete by module

* master:
  Further update DG for UI
  Update DG for UI and Architecture
  Update UG based on peer reviews
  Update UG styling
  Add link to jar file
  Refactor exit and help buttons to remove the MenuBar
  Style PersonDetails
  Update LogicComponent and Implementation
  Refactor DG
  Refactor inputs case-insensitive
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@jessica2828 jessica2828 added this to the v1.5 milestone Oct 31, 2024
@jessica2828 jessica2828 linked an issue Oct 31, 2024 that may be closed by this pull request
JYL27

This comment was marked as outdated.

@JYL27 JYL27 dismissed their stale review November 7, 2024 08:46

Checkstyle failure

JYL27 and others added 7 commits November 7, 2024 16:52
 into delete-command-tests

* 'delete-command-tests' of https://github.com/jessica2828/tp: (44 commits)
  Update src/test/java/seedu/address/logic/commands/DeleteCommandTest.java
  Change prefix in Help Message
  Minor bug fixes
  Minor bug fixes
  Refactor Tag to Role in .puml files
  Add EditCommand test
  Minor checkstyle fix
  Add test case for GradeCommand
  Fix checkstyle issue
  Add test case for ModuleCommand
  Add test case
  Remove unnecessary print statements and add test cases
  Minor checkstyle fix
  Fix ModuleCommand, DeleteCommand and GradeCommand such that PersonDetails updates when these commands are called
  Shift capitalisation and lowercase logic into ParserUtil class
  Fix UG formatting in PDF
  Refactor Tag to Role
  Add test case to DeleteCommandTest
  Fix bugs related to Find Command and Delete Command
  Delete irrelevant test
  ...

# Conflicts:
#	docs/DeveloperGuide.md
Copy link

@JYL27 JYL27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JYL27 JYL27 merged commit ac3a8b2 into AY2425S1-CS2103T-F15-2:master Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DeleteCommandTest
2 participants