forked from nus-cs2103-AY2425S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DeleteCommand tests #122
Merged
JYL27
merged 11 commits into
AY2425S1-CS2103T-F15-2:master
from
jessica2828:delete-command-tests
Nov 7, 2024
Merged
Update DeleteCommand tests #122
JYL27
merged 11 commits into
AY2425S1-CS2103T-F15-2:master
from
jessica2828:delete-command-tests
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Further update DG for UI Update DG for UI and Architecture Update UG based on peer reviews Update UG styling Add link to jar file Refactor exit and help buttons to remove the MenuBar Style PersonDetails Update LogicComponent and Implementation Refactor DG Refactor inputs case-insensitive
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
into delete-command-tests * 'delete-command-tests' of https://github.com/jessica2828/tp: (44 commits) Update src/test/java/seedu/address/logic/commands/DeleteCommandTest.java Change prefix in Help Message Minor bug fixes Minor bug fixes Refactor Tag to Role in .puml files Add EditCommand test Minor checkstyle fix Add test case for GradeCommand Fix checkstyle issue Add test case for ModuleCommand Add test case Remove unnecessary print statements and add test cases Minor checkstyle fix Fix ModuleCommand, DeleteCommand and GradeCommand such that PersonDetails updates when these commands are called Shift capitalisation and lowercase logic into ParserUtil class Fix UG formatting in PDF Refactor Tag to Role Add test case to DeleteCommandTest Fix bugs related to Find Command and Delete Command Delete irrelevant test ... # Conflicts: # docs/DeveloperGuide.md
JYL27
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes: