Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ModuleCommand Bug #254

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Fix ModuleCommand Bug #254

merged 2 commits into from
Nov 11, 2024

Conversation

btbrandon
Copy link

Key Change:

  • Refactor Module Command MESSAGE_CONSTRAINTS from "Modules should only contain alphanumeric characters and spaces, and it should not be blank" to "Modules should only contain alphanumeric characters, and it should not be blank". Modules should not include spaces.

@btbrandon btbrandon added this to the v1.6 milestone Nov 10, 2024
@btbrandon btbrandon linked an issue Nov 10, 2024 that may be closed by this pull request
[PE-D][Tester A] Adding of modules with space is blocked #179
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...c/main/java/seedu/address/model/person/Module.java 94.44% <ø> (ø) 11.00 <0.00> (ø)

jessica2828
jessica2828 approved these changes Nov 11, 2024
View reviewed changes
Copy link

@jessica2828 jessica2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessica2828 jessica2828 merged commit fc14b4a into AY2425S1-CS2103T-F15-2:master Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica2828 jessica2828 jessica2828 approved these changes

Assignees
No one assigned
Labels
severity.Low type.FunctionalityBug
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester A] Adding of modules with space is blocked
2 participants
@btbrandon @jessica2828