Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Functionality bugs #255

Merged

Conversation

btbrandon
Copy link

@btbrandon btbrandon commented Nov 10, 2024

Key Changes:

  • Refactor EditCommand to ensure that a command consisting of "m/" and any other prefix will throw an error message
  • Refactor Edit Command section in UG to document usage of edit command more clearly and specify which keywords are not supported for the respective command formats
  • Add test case in EditCommandParserTest to support the changes
  • Refactor MESSAGE_USAGE of Add, Delete, Edit, Find, Grade and Module commands for user-friendliness and standardisation
  • Fix bug in Filter Command section of UG where fullstop is inside quotation

- Refactor EditCommand to ensure that a command consisting of "m/" and any other prefix will throw an error message
- Refactor MESSAGE_USAGE of Add, Delete, Edit, Find, Grade and Module commands for user-friendliness and standardisation
- Fix bug in Filter Command section of UG where fullstop is inside quotation
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <100.00%> (ø) 8.00 <1.00> (ø)
...va/seedu/address/logic/commands/DeleteCommand.java 91.66% <100.00%> (+0.14%) 20.00 <1.00> (+1.00)
...java/seedu/address/logic/commands/EditCommand.java 93.43% <100.00%> (ø) 20.00 <0.00> (ø)
...java/seedu/address/logic/commands/FindCommand.java 100.00% <ø> (ø) 9.00 <0.00> (ø)
...ava/seedu/address/logic/commands/GradeCommand.java 100.00% <100.00%> (ø) 12.00 <1.00> (ø)
...va/seedu/address/logic/commands/ModuleCommand.java 100.00% <100.00%> (ø) 12.00 <1.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 100.00% <100.00%> (ø) 17.00 <0.00> (+6.00)
...c/main/java/seedu/address/model/person/Module.java 94.44% <ø> (ø) 11.00 <0.00> (ø)

Copy link

@ethan-goh ethan-goh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessica2828 jessica2828 merged commit 4d665f7 into AY2425S1-CS2103T-F15-2:master Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants