Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firooz1/feat/informative email with file name #34

Merged
merged 24 commits into from
Dec 18, 2024

Conversation

hsnfirooz
Copy link
Member

@hsnfirooz hsnfirooz commented Nov 19, 2024

This is covering #37, #33, and #21.

Also it adds file attachment support for OOD app to send the results via email.

@hsnfirooz hsnfirooz marked this pull request as ready for review November 20, 2024 07:36
hsnfirooz and others added 13 commits November 20, 2024 09:42
Instead of logger warning, now the script raises an exception in case of missing a file
alert for empty file path, and also a warning for requesting results via email to consider confidenciality
This addresses issue #37, and replace concatenating the unknown arguments with handling as a list
to be more user-friendly, this setting allows hidding advance options for advance users
This commit makes the complete stage user friendly, by adding buttons to the result and log folder.
Remove arrayjob reference.
@ruokolt
Copy link
Contributor

ruokolt commented Dec 18, 2024

Looks good! I can try to make the merge.

@ruokolt ruokolt merged commit 54a11be into main Dec 18, 2024
2 checks passed
@ruokolt ruokolt deleted the firooz1/feat/informative-email-with-file-name branch December 18, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants