Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure/Disable certain notifications for a user #2696

Closed
2 tasks done
Tracked by #1055
sleidig opened this issue Dec 2, 2024 · 7 comments · Fixed by #2712
Closed
2 tasks done
Tracked by #1055

Configure/Disable certain notifications for a user #2696

sleidig opened this issue Dec 2, 2024 · 7 comments · Fixed by #2712
Assignees
Milestone

Comments

@sleidig
Copy link
Member

sleidig commented Dec 2, 2024

To allow users to enable or disable various notification types in the UI:

  • Create the multi-select option on the user profile page, allowing users to select the notification types they want to receive.
  • Implement the Notification setting UI according to this suggested UI

For details on the required database updates, here is the discussion:
#2690 (comment)

@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Dec 2, 2024
@sleidig sleidig added this to the Notifications milestone Dec 2, 2024
@sleidig sleidig moved this from Triage / Analysis to Planned (current "sprint") in All Tasks & Issues Dec 2, 2024
@sleidig sleidig moved this from Planned (current "sprint") to Todo (ready for work) in All Tasks & Issues Dec 2, 2024
@sleidig sleidig moved this from Todo (ready for work) to Planned (current "sprint") in All Tasks & Issues Dec 10, 2024
@Ayush8923 Ayush8923 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Dec 10, 2024
@Ayush8923
Copy link
Contributor

@sleidig We can design the UI for Notification Types similar to the layout shown in the below-attached screenshot. On the Profile page, we can add a new tab next to the User Account tab, named Notification Settings.

When the user clicks on the Notification Settings tab, a new page will open. This page will display a list of notification types, such as Children, Student, etc., as shown in the screenshot.

Under the label Where you receive notifications, we will specify the platforms where notifications are available, such as through the browser and Email (we can implement this functionality in future). Also, If notification permissions are not granted by the user, there should be an option to enable the necessary permissions.

This page can also be accessed directly from the Notification List. Please let me know your thoughts and suggestions on this.

image

@sleidig
Copy link
Member Author

sleidig commented Dec 10, 2024

This looks great! I like the individual toggling for each type but having the "where you receive" as a central setting separately.

For the "What notifications" section, I could imagine a listing if different active and standard notification types and then a button to "add new notification rule" for configuring an additional custom trigger (e.g. a very special filter to get informed about a sub-type of certain entities). A bit like this (as a sample of the logic, not necessarily for the exact UI):
image

Such custom notification triggers (in contrast to default general notification types) should also offer to get deleted rather than just deactivated.

@sleidig sleidig moved this from In Progress to Planned (current "sprint") in All Tasks & Issues Dec 11, 2024
@Ayush8923 Ayush8923 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Dec 12, 2024
@Ayush8923 Ayush8923 moved this from In Progress to Functional Review in All Tasks & Issues Dec 17, 2024
@Ayush8923 Ayush8923 linked a pull request Dec 17, 2024 that will close this issue
2 tasks
@Ayush8923 Ayush8923 moved this from Functional Review to Technical Review in All Tasks & Issues Dec 18, 2024
@Abhinegi2
Copy link
Contributor

@Ayush8923
can we add some text like this -
Image

@Ayush8923
Copy link
Contributor

Ayush8923 commented Dec 19, 2024

As per discussion on call, here is the todos for Notification setting UI Updates

Descriptions

  • Update the description for the Notification Settings top title.
  • Add a description to the What notifications you receive title.
  • Add a description to the Where You Receive Notifications title.

Dynamic Saving

  • Remove the Save and Cancel buttons and implement dynamic saving functionality.
  • Move the Add New Notification Rule button below the notification rule row, for reference, here this suggested UI

Editing Notification Rule block

  • Add an information icon to the following:
    • Select Entity Type
    • Notification Condition
    • Notification center
    • Push Notification inside the Where you receive notifications section
  • Need to update the above mention information icon text
  • Update the tooltip text in the toggle button
  • adapt layout (wider input fields, etc.)

Default Settings

  • If no notification settings are selected by the user, add a default entry for each field. (We will update this logic with this Notification Setting Logic issue)

Test Trigger Button

  • Add a Test Trigger button to each notification rule so users can preview how the notification will appear.

Section Updates

  • Update the Where You Receive Notifications section:
    • Add Email Notifications with a Coming Soon label and keep it disabled.
    • Add "Notifiction Center" option without a disable-toggle but with a information icon tooltip

Delete Option

  • When the user clicks on the delete button then the confirmation pop-up should be open, user wants to delete the notification rule or not.

@sleidig @george-neha I have added the todos for notification UI updates, please take a look and let me know if I missed anything. Also, I will update the notification setting logic issue description based on this discussion.

@sleidig sleidig moved this from Technical Review to In Progress in All Tasks & Issues Dec 19, 2024
@Ayush8923
Copy link
Contributor

@sleidig @george-neha I have updated the notification settings UI according to the suggestions mentioned above. Could you please have a look and let me know if any updates or changes are needed? For reference, here is the screenshot.

  1. Notification setting UI
image
  1. Notification setting page with deleted confirmation alert
image

Also, @george-neha, could you please share the updated descriptions for the fields, so that I can update them here?

@george-neha
Copy link

@sleidig @Ayush8923
Two suggestions:
1.The "where you receive notifications" section should be moved up. In situations where multiple notification conditions are added, selecting where the notifications should be received requires scrolling down to enable or disable them.
image
2.The "Notification Center" can be disabled or greyed out, as only push notifications are currently available. The user will interact with a dropdown that is, in fact, disabled.
image

@Ayush8923
Copy link
Contributor

@george-neha

  1. If the Where you receive notifications section is placed above the What notification you receive section, the latter will move below. In this scenario, users would still need to scroll down to add more notification rules. However, the What notification you receive section seems more important for users. What do you suggest/think?
  2. Yes. For now, the Notification Center dropdown is disabled. However, as far as I have checked, the system has globally set the selected value's colour to black for better readability as we disable forms by default

@Ayush8923 Ayush8923 moved this from In Progress to Functional Review in All Tasks & Issues Dec 24, 2024
@sleidig sleidig moved this from Functional Review to In Progress in All Tasks & Issues Dec 27, 2024
@Ayush8923 Ayush8923 moved this from In Progress to Functional Review in All Tasks & Issues Jan 2, 2025
@Ayush8923 Ayush8923 moved this from Functional Review to Technical Review in All Tasks & Issues Jan 2, 2025
@sleidig sleidig moved this from Technical Review to Done in All Tasks & Issues Jan 3, 2025
@sleidig sleidig closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants