Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Notification Setting Page #2712

Merged
merged 168 commits into from
Jan 3, 2025
Merged

[Feat]: Notification Setting Page #2712

merged 168 commits into from
Jan 3, 2025

Conversation

Ayush8923
Copy link
Contributor

@Ayush8923 Ayush8923 commented Dec 12, 2024 •
edited
Loading

closes: #2696

Visible/Frontend Changes

  • Create the notification setting page inside the profile page.
  • Create the notification setting page according to this suggested UI.

Ayush8923 and others added 30 commits November 27, 2024 10:32
@Ayush8923
feat(*): firebase integration for push notification
832f23a
@Ayush8923
feat(*): create the wrapper function for the firebase messaging
04b6672
@Ayush8923
feat(*): create the push notification UI
c29861f
@Ayush8923
fix(*): update the notification UI alignment
6e7ed4b
@Ayush8923
fix(*): update the notification UI styling
5293440
@Ayush8923
fix(*): update the notification list UI
afac897
@Ayush8923
fix
4f60d7c
@Ayush8923
fix(*): update the aam digital firebase credintals
4199026
@Ayush8923
fix(*): refactore the push notification service and create the new No…
91b6a2e 
…tification entity in system
@Ayush8923
feat(*): integrate the firebase send api to send the notification to …
30132b1 
…the user devices
@Ayush8923
fix(*): remove the hardcoded project ID
3e3562c
@Ayush8923
fix(*): update the notification entity fields
0dae24c
@Ayush8923
fix(*): implement the get the notification list and cleanups
c13bfe6
@Ayush8923
fix(*): linting checks
c277454
@Ayush8923
fix(*): added the padding in the notification item class
6e30e7a
@Ayush8923
Merge branch 'master' into feat/push-notification-firebase-integration
3896fcf
@Ayush8923
fix(*): update the firebaseConfig import
9d20b82
@Ayush8923
Merge branch 'feat/push-notification-firebase-integration' of https:/…
c384ebd 
…/github.com/Aam-Digital/ndb-core into feat/push-notification-firebase-integration
@Ayush8923
fix(*): added the firebase config in the environment prod and spec file
7af4344
@Ayush8923
fix(*): linting checks fixes
71ed3b4
@Ayush8923
feat(*): update the notification list UI
7da91d3
@Ayush8923
fix*(*): fix the indentation
e0961ee
@Ayush8923
fix(*): update the notification list UI
da0a887
@Ayush8923
fix(*): cleanups and refactoring
d3eaa1a
@Ayush8923
fix(*): update the code description
457e7d6
@Ayush8923
fix(*): added the logging
ef93d0d
@Ayush8923
fix(*): cleanups
5c37352
@Ayush8923
fix(*): remove the unwanted styles
1d05768
@Ayush8923
fix(*): minor updates on the markAsRead Logic and cleanups
c7f38e0
@Ayush8923
fix(*): update the notification setting item
73329b0
@Ayush8923
Copy link
Contributor Author

I like it. If we have the enabled badge there, maybe turn the warning icon into a red "disabled " badge for consistency and better visibility?

Thanks for this suggestion, I have updated the UI according. So if the push notification is enabled then the Enabled badge is showing next to the Where you receive notifications section and if the push notification is disabled then the Disabled badge is showing.

@Ayush8923
Copy link
Contributor Author

Deployed to https://pr-2712.aam-digital.net/

@george-neha I'm Moving this to Functional Review. You can test the changes using the link provided link above. Please let me know if any further adjustments are needed or if you have any suggestions.

@Ayush8923 Ayush8923 requested a review from sleidig January 2, 2025 11:02
@george-neha george-neha removed their request for review January 2, 2025 14:55
sleidig
sleidig requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last glitches, otherwise both code and UI look good 👍

src/app/core/entity/entity-type-select/entity-type-select.component.ts Outdated Show resolved Hide resolved
src/app/features/notification/notification-settings/notification-settings.component.scss Outdated Show resolved Hide resolved
src/app/features/notification/notification-settings/notification-settings.component.scss Outdated Show resolved Hide resolved
src/app/features/notification/notification-settings/notification-settings.component.scss Outdated Show resolved Hide resolved
@Ayush8923 Ayush8923 requested a review from sleidig January 3, 2025 13:40
sleidig
sleidig approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙂

@sleidig sleidig mentioned this pull request Jan 3, 2025
Merged
@sleidig sleidig merged commit d4b7627 into feat/1055_notifications-final Jan 3, 2025
12 checks passed
@sleidig sleidig deleted the feat/notification-setting-page branch January 3, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees

@Ayush8923 Ayush8923

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure/Disable certain notifications for a user
4 participants
@Ayush8923 @george-neha @sleidig @Abhinegi2