[Feat]: Notification setting logic updates #2752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tification entity in system
…/github.com/Aam-Digital/ndb-core into feat/push-notification-firebase-integration
…am-Digital/ndb-core into feat/notification-setting-logic-updates
…am-Digital/ndb-core into feat/notification-setting-logic-updates
…setting-logic-updates
Base automatically changed from
feat/notification-setting-page
to
feat/1055_notifications-final
January 3, 2025 16:06
…m-Digital/ndb-core into feat/notification-setting-logic-updates
…m-Digital/ndb-core into feat/notification-setting-logic-updates
sleidig
requested changes
Jan 6, 2025
| @@ -45,79 +48,271 @@ import { ConfirmationDialogService } from "app/core/common-components/confirmati | |||
| templateUrl: "./notification-settings.component.html", | |||
| styleUrl: "./notification-settings.component.scss", | |||
| }) | |||
| export class NotificationSettingsComponent { | |||
| hasPushNotificationEnabled: boolean = false; | |||
| export class NotificationSettingsComponent implements OnInit { | |||
There was a problem hiding this comment.
with the many fields and arrays, the template and logic is starting to become quite complicated. I would suggest to extract a component the represents the config of a single notificationRule:
class NotificationRuleComponent {
@Input() notificationRule: NotificationRule;
/**
* Emits whenever a detail about the notification rule was changed by the user.
*/
@Output() notificationRuleChange: EventEmitter<NotificationRule>();
...
}
Within this all the different UI and property updates can be handled and to the outside (the NotifciationSettingsComponent), things are communicated through a single input and output. Test notifications etc. can be handled within that component also
| // TODO: If the user to not allow the permission then don't need to update the value. | ||
| const NotificationToken = this.getNotificationToken(); | ||
| const notificationConfig = await this.loadNotificationConfig(); | ||
| this.isPushNotificationEnabled = event.checked; |
There was a problem hiding this comment.
Is requesting notification permissions handled in a different PR / issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2723
Visible/Frontend Changes
Where you receive notificationssection in the notification settings page, the value is updated accordingly in the CouchDB.