-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: Notification setting logic updates #2752
[Feat]: Notification setting logic updates #2752
Conversation
…tification entity in system
…/github.com/Aam-Digital/ndb-core into feat/push-notification-firebase-integration
src/app/features/notification/notification-settings/notification-settings.component.ts
Show resolved
Hide resolved
src/app/features/notification/notification-settings/notification-settings.component.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a fairly major further refactoring to simplify the layers of formControls and methods. Please have a look at the latest code and check if you find any errors or have further suggestions, @Ayush8923
Thank you, @sleidig, for refactoring the formControl. It looks much better now. However, there was a minor issue where, if the user had already chosen I have checked the functionality, and it's working well. Could you please review the final changes once? If any further modifications are needed, please let me know. Otherwise, the PR is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for testing and improving! Unfortunately I had to remove the notifcation-method-select component to make all the properties work with formControls easily but taking the options out into a variable is a good approach
closes: #2723
Visible/Frontend Changes
Where you receive notifications
section in the notification settings page, the value is updated accordingly in the CouchDB.