Fix/public form improvements #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-2753.aam-digital.net/ |
… fix/public-form-imoprovements
… fix/public-form-imoprovements
… fix/public-form-imoprovements
sleidig
reviewed
Jan 6, 2025
| } | ||
|
|
||
| .public-form-image { | ||
| max-width: 100%; | ||
| height: 100px; | ||
| object-fit: contain; |
There was a problem hiding this comment.
now, if screen is small enough / image wide enough, the image gets distorted again:
If we consider a scenario with wide banner and common usage on mobile, this is will lead to problems.
There was a problem hiding this comment.
added as new issue (to close this PR quickly): #2776
src/app/features/public-form/edit-public-form-columns/edit-public-form-columns.component.ts
Show resolved
Hide resolved
...app/features/public-form/edit-public-form-columns/edit-public-form-columns.component.spec.ts
Outdated
Show resolved
Hide resolved
sleidig
approved these changes
Jan 6, 2025
|
🎉 This PR is included in version 3.45.0-master.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.45.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
sleidig
added a commit
that referenced
this pull request
Jan 7, 2025
* fix extra scrollbar * image center align * migration to convert old column config for admin view * added markdown guide + explanation * support field group headers in public forms * enable markdown in Public Form description --------- Co-authored-by: Sebastian Leidig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2725
Visible/Frontend Changes
Architectural/Backend Changes