Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dependencies #2818

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Fix circular dependencies #2818

wants to merge 20 commits into from

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Jan 28, 2025

run npm run check-circular-deps
and go through each of the detected issues:

  1. Look at the imports of the files to understand what is imported where ...
  2. if there is some export (a class, interface, variable, etc.) that can be moved to a new file, fix the circular dependency by creating a new file, moving it there and importing that new file in the affected files (so that they only depend on the third file but not on each other)
  3. if it is not clear how the imports can be separated and fixed, write down here what you found
  • the files affected
  • what they import from each other
  • briefly describe why it is difficult to separate it
  1. make a git commit (for 2. above) or a github comment (for 3. above) for the circular dependency issue you worked on and then move on to the next line of the "npm run check-circular-deps"

Copy link
Contributor

Deployed to https://pr-2818.aam-digital.net/

@sleidig sleidig marked this pull request as draft January 28, 2025 10:26
@sleidig
Copy link
Member Author

sleidig commented Jan 30, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Technical Review
Development

Successfully merging this pull request may close these issues.

2 participants