Update example script to version stable ^2.0 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytroklyman
changed the title
bitsbauer
approved these changes
Apr 8, 2021
viktor-br
approved these changes
Apr 8, 2021
AbcAeffchen
requested changes
Apr 8, 2021
| @@ -18,7 +18,8 @@ | |||
| use AbcAeffchen\SepaUtilities\SepaUtilities; | |||
| use AbcAeffchen\Sephpa\SephpaDirectDebit; | |||
|
|
|||
| require_once '../src/Sephpa.php'; | |||
| chdir(dirname(__DIR__)); | |||
There was a problem hiding this comment.
This line seems to be unnecessary.
| @@ -18,7 +18,8 @@ | |||
| use AbcAeffchen\SepaUtilities\SepaUtilities; | |||
| use AbcAeffchen\Sephpa\SephpaDirectDebit; | |||
|
|
|||
| require_once '../src/Sephpa.php'; | |||
| chdir(dirname(__DIR__)); | |||
| require __DIR__ . '/../vendor/autoload.php'; | |||
There was a problem hiding this comment.
The vendor folder is not part of the repository. There should be a note, that is requires composer. Additionally a comment with instructions to use this without composer would be nice. This is basically using src/autoloader.php and SepaUtilities.php that needs to be downloaded separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated example.php script to work with stable ^2.0 versions.