Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixify #95

Closed
wants to merge 7 commits into from
Closed

Nixify #95

wants to merge 7 commits into from

Conversation

HannesGitH
Copy link

Description

introduction of a nix flake, this allows reproducible, deterministic builds.

As a side effect it also allows nix users to nix run github:Abdenasser/neohtop

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@HannesGitH HannesGitH marked this pull request as ready for review November 10, 2024 23:07
@Abdenasser
Copy link
Owner

@HannesGitH thank you for working on that, but I really think this is not a priority right now (I haven't really seen people asking for nix build support) so I believe we should just hold off until there's more demand.. I would really appreciate it if you can work on some of the other issues meanwhile.. thanks again

@HannesGitH
Copy link
Author

Sure thing, no worries. Wanted to make it work anyway and now that it does I can instead add it downstream to nixpkgs, you don't have to see it again ;)
But just in case first party support should be planned anyway (maybe way in the future) this is how it could be done :P

@HannesGitH
Copy link
Author

HannesGitH commented Nov 11, 2024

For any nix user stumbling upon this, I'll probably open a pr to nixpkgs soon, in the meantime you can nix run GitHub:hannesgith/neohtop?ref=nixify

edit: here it is: NixOS/nixpkgs#356826

@Abdenasser Abdenasser closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants