Fixing hardcoded version values for jacoco report GH Action.

AbsaOSS · May 2, 2024 · d0174fa · d0174fa
1 parent 559c24a
commit d0174fa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/jacoco_check.yml b/.github/workflows/jacoco_check.yml
@@ -22,9 +22,9 @@ on:
     types: [ opened, edited, synchronize, reopened ]
 
 env:
+  jacocoReportVersion: "v1.6.1"
   scalaLong12: 2.13.11
   scalaShort12: "2.13"
-  jaCocoReportVersion: "v1.6.1"
   overall: 60.0
   changed: 80.0
 
@@ -50,7 +50,7 @@ jobs:
       - name: Add coverage to PR
         if: steps.jacocorun.outcome == 'success'
         id: jacoco-agent
-        uses: madrapps/jacoco-report@v1.6.1
+        uses: madrapps/jacoco-report@${{ env.jacocoReportVersion }}
         with:
           name: agent-jacoco-report
           paths: ${{ github.workspace }}/agent/target/jvm-${{ env.scalaShort12 }}/jacoco/report/jacoco.xml
@@ -63,7 +63,7 @@ jobs:
       - name: Add coverage to PR
         if: steps.jacocorun.outcome == 'success'
         id: jacoco-model
-        uses: madrapps/jacoco-report@${{ env.jaCocoReportVersion }}
+        uses: madrapps/jacoco-report@${{ env.jacocoReportVersion }}
         with:
           name: model-jacoco-report
           paths: ${{ github.workspace }}/model/target/jvm-${{ env.scalaShort12 }}/jacoco/report/jacoco.xml

diff --git a/.github/workflows/jacoco_check_server.yml b/.github/workflows/jacoco_check_server.yml
@@ -22,6 +22,7 @@ on:
     types: [ opened, edited, synchronize, reopened ]
 
 env:
+  jacocoReportVersion: "v1.6.1"
   scalaLong13: 2.13.11
   scalaShort13: "2.13"
   overall: 75.0
@@ -63,7 +64,7 @@ jobs:
       - name: Add coverage to PR
         if: steps.jacocorun.outcome == 'success'
         id: jacoco-server
-        uses: madrapps/jacoco-report@v1.6.1
+        uses: madrapps/jacoco-report@${{ env.jacocoReportVersion }}
         with:
           paths: ${{ github.workspace }}/server/target/jvm-${{ env.scalaShort13 }}/jacoco/report/jacoco.xml
           token: ${{ secrets.GITHUB_TOKEN }}