Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DB function to gather partitioning measure definitions #137

Closed
benedeki opened this issue Dec 5, 2023 · 0 comments · Fixed by #157
Closed

Create DB function to gather partitioning measure definitions #137

benedeki opened this issue Dec 5, 2023 · 0 comments · Fixed by #157
Assignees
@TebaleloS
Labels
DB Issues touching the Database part of the project enhancement New feature or request
Milestone
Atum release 0.2

Comments

@benedeki
Copy link
Contributor

benedeki commented Dec 5, 2023 •
edited
Loading

Background

We need to read the partitioning information.

Feature

Create DB function to gather partitioning measure definitions.

Proposed Solution

Function signature

CREATE OR REPLACE FUNCTION runs.get_partitioning_measures(
    IN  i_partitioning                      JSONB,
    OUT measure_name                        TEXT,
    OUT measured_columns                    TEXT[]
) RETURNS SETOF record AS
@benedeki benedeki added the enhancement New feature or request label Dec 5, 2023
@benedeki benedeki moved this to 📋 Backlog in CPS small repos project Dec 5, 2023
@benedeki benedeki added this to the Next major release milestone Dec 5, 2023
@benedeki benedeki added the DB Issues touching the Database part of the project label Dec 5, 2023
TebaleloS added a commit that referenced this issue Feb 13, 2024
@TebaleloS
Fixes #137 - defined and implemented get_partitioning_measures
49aae64
TebaleloS added a commit that referenced this issue Feb 13, 2024
@TebaleloS
Merge branch 'master' into feature/#137-Create-DB-function-to-gather-…
cdf8a94 
…partitioning-measure-definitions
@TebaleloS TebaleloS mentioned this issue Feb 13, 2024
Merged
TebaleloS added a commit that referenced this issue Feb 13, 2024
@TebaleloS
Closes #137
8c8008e
TebaleloS added a commit that referenced this issue Feb 15, 2024
@TebaleloS
Closes #137 - saving changes
1546d77
TebaleloS added a commit that referenced this issue Feb 15, 2024
@TebaleloS
Closes #137 - fixed get_partitioning_measures function
58af24c
TebaleloS added a commit that referenced this issue Feb 16, 2024
@TebaleloS
Fixes #137
4f8f49c
TebaleloS added a commit that referenced this issue Feb 19, 2024
@TebaleloS
Fixes #137 - refactored db function and the test cases
158d54c
TebaleloS added a commit that referenced this issue Feb 19, 2024
@TebaleloS
Merge branch 'master' into feature/#137-Create-DB-function-to-gather-…
ecba9ac 
…partitioning-measure-definitions
TebaleloS added a commit that referenced this issue Feb 20, 2024
@TebaleloS
Closes #137 - removed print statements
40cdf76
@benedeki benedeki mentioned this issue Feb 22, 2024
Merged
TebaleloS added a commit that referenced this issue Feb 22, 2024
@TebaleloS
Fixes #137 - catered for partitioning without measures
d8e92c5
TebaleloS added a commit that referenced this issue Feb 23, 2024
@TebaleloS
Fixes #137 - implemented the test cases
19ae373
TebaleloS added a commit that referenced this issue Feb 23, 2024
@TebaleloS
Fixes #137 - Implemented github comment
81eaf94
TebaleloS added a commit that referenced this issue Feb 23, 2024
@TebaleloS
Merge branch 'master' into feature/#137-Create-DB-function-to-gather-…
9eee293 
…partitioning-measure-definitions
TebaleloS added a commit that referenced this issue Feb 28, 2024
@TebaleloS
Fixes #137 - applied github comment
cc2acf0
TebaleloS added a commit that referenced this issue Feb 28, 2024
@TebaleloS
Fixes #137 - applied github comment
b9e51ce
TebaleloS added a commit that referenced this issue Feb 29, 2024
@TebaleloS
Fixes #137 - addressing github comment
f566246
TebaleloS added a commit that referenced this issue Feb 29, 2024
@TebaleloS
Fixes #137 - Correcting the status text
10d003b
TebaleloS added a commit that referenced this issue Feb 29, 2024
@TebaleloS @benedeki @lsulak
defined and implemented get_partitioning_measures:#137 (#157)
d7123aa 
* Fixes #137 - defined and implemented get_partitioning_measures

* Closes #137

* Closes #137 - saving changes

* Closes #137 - fixed get_partitioning_measures function

* Fixes #137

* Fixes #137 - refactored db function and the test cases

* Closes #137 - removed print statements

* Fixes #137 - catered for partitioning without measures

* Fixes #137 - implemented the test cases

* Fixes #137 - Implemented github comment

* Update database/src/main/postgres/runs/V1.5.11__get_partitioning_measures.sql

Co-authored-by: David Benedeki <[email protected]>

* Update database/src/main/postgres/runs/V1.5.11__get_partitioning_measures.sql

Co-authored-by: Ladislav Sulak <[email protected]>

* Update database/src/main/postgres/runs/V1.5.11__get_partitioning_measures.sql

Co-authored-by: Ladislav Sulak <[email protected]>

* Update database/src/test/scala/za/co/absa/atum/database/runs/GetPartitioningMeasuresTest.scala

Co-authored-by: Ladislav Sulak <[email protected]>

* Fixes #137 - applied github comment

* Fixes #137 - applied github comment

---------

Co-authored-by: David Benedeki <[email protected]>
Co-authored-by: Ladislav Sulak <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in CPS small repos project Feb 29, 2024
TebaleloS added a commit that referenced this issue Mar 6, 2024
@TebaleloS
Implemented get_partitioning_additional_data:#138 (#158)
d89812e 
* Closes #138 - Implemented get_partitioning_additional_data

* Closes #138 - Added versioning on the newly created file

* Closes #138 - refactored file name

* Fixes #138 - refactored db function

* Fixes #137 - addressing github comment

* Fixes #137 - Correcting the status text

* Fixes #138 - Implementing test cases

* Fixes #138 - Implementing test cases

* Fixes #138 - Adding license

* Close #138 - Applied GitHub comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TebaleloS TebaleloS

Labels
DB Issues touching the Database part of the project enhancement New feature or request
Projects
CPS small repos project
Archived in project
Milestone
Atum release 0.2
Development

Successfully merging a pull request may close this issue.

defined and implemented get_partitioning_measures:#137 AbsaOSS/atum-service
2 participants
@benedeki @TebaleloS