Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defined and implemented get_partitioning_measures:#137 #157

Merged
merged 19 commits into from
Feb 29, 2024
Merged

defined and implemented get_partitioning_measures:#137 #157

merged 19 commits into from
Feb 29, 2024

Conversation

TebaleloS
Copy link
Collaborator

@TebaleloS TebaleloS commented Feb 13, 2024 •
edited
Loading

  • Defined and implemented get_partitioning_measures.
  • Added test cases but feel free to test with any size of the partitioning, as long as that partitioning exist in the database.

closes #137

@TebaleloS TebaleloS self-assigned this Feb 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 66.35% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

JaCoCo agent module code coverage report - scala 2.12.18

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

JaCoCo model module code coverage report - scala 2.12.18

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@TebaleloS TebaleloS marked this pull request as ready for review February 13, 2024 08:52
lsulak
lsulak reviewed Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, well done! I found a few improvements but it works in general.

  • code reviewed
  • pulled
  • built
  • ran tests
  • ran the function on my local PG instance

@benedeki
Copy link
Contributor

Resolving addressed issues in pair programming session.

benedeki
benedeki approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@benedeki benedeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified things together. Looks good now, tests passed locally.

@TebaleloS TebaleloS merged commit d7123aa into master Feb 29, 2024
10 checks passed
@TebaleloS TebaleloS deleted the feature/#137-Create-DB-function-to-gather-partitioning-measure-definitions branch February 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsulak lsulak lsulak left review comments

@benedeki benedeki benedeki approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

@salamonpavel salamonpavel Awaiting requested review from salamonpavel salamonpavel is a code owner

Assignees

@TebaleloS TebaleloS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create DB function to gather partitioning measure definitions
3 participants
@TebaleloS @benedeki @lsulak