Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#127 Review SBT files and CI yamls #136

Merged
merged 35 commits into from
Feb 12, 2024
Merged

#127 Review SBT files and CI yamls #136

merged 35 commits into from
Feb 12, 2024

Conversation

Zejnilovic
Copy link
Contributor

  • few whitespace cleanups and moves
  • rename limitVersion to truncateVerions and reuse it
  • fix logging of spark and scala version per modulea
  • block publishing of war files to maven central
  • update project description
  • update jacoco build to use variables instead of matrix
  • update release yaml to publish WAR to a draft PR

Closes #127

@benedeki I would like to 1st discuss your list in the ticket before I add it.

@Zejnilovic
#127 Review SBT files and CI yamls
2a6aa72 
- few whitespace cleanups and moves
- rename limitVersion to truncateVerions and reuse it
- fix logging of spark and scala version per modulea
- block publishing of war files to maven central
- update project description
- update jacoco build to use variables instead of matrix
- update release yaml to publish WAR to a draft PR
@Zejnilovic Zejnilovic self-assigned this Dec 1, 2023
miroslavpojer
miroslavpojer reviewed Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • built
  • code review
  • unit test run
  • jacoco run - 2 comments

miroslavpojer
miroslavpojer reviewed Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • built
  • test run - passing
  • jacoco run - local run
  • jacoco run - GH Action - see review comments

miroslavpojer
miroslavpojer reviewed Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more changes to get it running.

miroslavpojer
miroslavpojer reviewed Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more suggestions.

miroslavpojer
miroslavpojer previously approved these changes Dec 4, 2023
View reviewed changes
@Zejnilovic Zejnilovic marked this pull request as ready for review December 4, 2023 15:54
benedeki
benedeki reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@benedeki benedeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot judge on Jacoco setup.

Also does this configuration removed the creation of atum_agent librbari without Spark and Scala designation? I don't see it there, sorry.

lsulak
lsulak reviewed Dec 11, 2023
View reviewed changes
lsulak
lsulak reviewed Dec 15, 2023
View reviewed changes
lsulak
lsulak reviewed Dec 15, 2023
View reviewed changes
benedeki
benedeki previously approved these changes Feb 11, 2024
View reviewed changes
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Feb 12, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Feb 12, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Feb 12, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Feb 12, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Feb 12, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Feb 12, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Feb 12, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Feb 12, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Feb 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 62.13% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

JaCoCo agent module code coverage report - scala 2.12.18

Overall Project 73.43% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

JaCoCo model module code coverage report - scala 2.12.18

Overall Project 74.23% ❌

There is no coverage information present for the Files changed

miroslavpojer
miroslavpojer approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jacoco failure management fixed.

benedeki
benedeki approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@benedeki benedeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you @Zejnilovic

@Zejnilovic Zejnilovic merged commit eae92e4 into master Feb 12, 2024
8 checks passed
@Zejnilovic Zejnilovic deleted the feature/127-review-sbt-and-ci branch February 12, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsulak lsulak lsulak left review comments

@benedeki benedeki benedeki approved these changes

@miroslavpojer miroslavpojer miroslavpojer approved these changes

@TebaleloS TebaleloS Awaiting requested review from TebaleloS

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

@salamonpavel salamonpavel Awaiting requested review from salamonpavel salamonpavel is a code owner

Assignees

@Zejnilovic Zejnilovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review SBT files
4 participants
@Zejnilovic @miroslavpojer @lsulak @benedeki