Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#22 Add Spike template fix #173

Merged
merged 6 commits into from
Mar 18, 2024
Merged

#22 Add Spike template fix #173

merged 6 commits into from
Mar 18, 2024

Conversation

benedeki
Copy link
Contributor

@benedeki benedeki commented Mar 18, 2024 •
edited
Loading

  • Fix file location

Closes #174

@github-actions GitHub Actions
Copy link

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 73.69% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 60.65% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 56.33% ❌

There is no coverage information present for the Files changed

lsulak
lsulak reviewed Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, don't you want to remove file https://github.com/AbsaOSS/atum-service/blob/master/.github/workflows/spike_task.md ?

@benedeki
Copy link
Contributor Author

Also, don't you want to remove file https://github.com/AbsaOSS/atum-service/blob/master/.github/workflows/spike_task.md ?

Funny how Git sometime detects a move and sometimes now. Thanks for noticing.

@benedeki benedeki force-pushed the feature/22-add-spike-template-fix branch from 16e7578 to b8e340a Compare March 18, 2024 15:13
@lsulak
Copy link
Collaborator

lsulak commented Mar 18, 2024

Also, don't you want to remove file https://github.com/AbsaOSS/atum-service/blob/master/.github/workflows/spike_task.md ?

Funny how Git sometime detects a move and sometimes now. Thanks for noticing.

depends how you use it maybe. In terminal I don't have any non-determinism, never had I think

@benedeki benedeki merged commit a1117f9 into master Mar 18, 2024
10 checks passed
@benedeki benedeki deleted the feature/22-add-spike-template-fix branch March 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsulak lsulak lsulak approved these changes

@TebaleloS TebaleloS Awaiting requested review from TebaleloS

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

@salamonpavel salamonpavel Awaiting requested review from salamonpavel salamonpavel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Spike template
2 participants
@benedeki @lsulak