Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#211: Release notes entry enforcement #212

Merged
merged 32 commits into from
Jun 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e77987e
#211: Release notes entry enforcement
benedeki Jun 13, 2024
0b2b7d1
Merge branch 'master' into feature/211-release-notes-entry-enforcement
lsulak Jun 13, 2024
6e0afae
* added on-issue-comment trigger
benedeki Jun 14, 2024
6688ff6
* testing
benedeki Jun 14, 2024
ac2ed7a
* experimenting with on-issue-comment
benedeki Jun 14, 2024
8935beb
* further experimenting
benedeki Jun 14, 2024
1ade8a4
* test X
benedeki Jun 14, 2024
19a773c
* test XI
benedeki Jun 14, 2024
e1b0775
* test XII
benedeki Jun 14, 2024
f92d564
* test XII
benedeki Jun 14, 2024
7b83c24
* Test XIII
benedeki Jun 14, 2024
ac0738e
Update .github/workflows/release_draft.yml
benedeki Jun 14, 2024
829b97c
Merge branch 'master' into feature/211-release-notes-entry-enforcement
benedeki Jun 14, 2024
8b3e36d
* Experiment XIV
benedeki Jun 17, 2024
d65f890
Merge branch 'feature/211-release-notes-entry-enforcement' of https:/…
benedeki Jun 17, 2024
f2a700c
* Experiment XV
benedeki Jun 17, 2024
615359a
* Experiment XVI
benedeki Jun 17, 2024
58b8b56
* added test filenames check action
benedeki Jun 18, 2024
bdaec35
Merge branch 'master' into feature/211-release-notes-entry-enforcement
benedeki Jun 18, 2024
b7ca0b7
* fixes
benedeki Jun 19, 2024
d41d26c
Merge branch 'feature/211-release-notes-entry-enforcement' of https:/…
benedeki Jun 19, 2024
50be6b2
Apply suggestions from code review
benedeki Jun 20, 2024
d40d31e
* removed demo code
benedeki Jun 20, 2024
157deaa
* Fixes
benedeki Jun 20, 2024
ea02daa
* Fixed filename patterns
benedeki Jun 20, 2024
d00bd4d
* added excludes
benedeki Jun 20, 2024
ab081b5
* better alignment
benedeki Jun 21, 2024
4893740
* Typo fix
benedeki Jun 23, 2024
b921521
* still wrong
benedeki Jun 23, 2024
7592de1
* multi-line needs different style
benedeki Jun 23, 2024
883cf28
* last try
benedeki Jun 23, 2024
3f632f8
* back to one line excludes
benedeki Jun 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
* back to one line excludes
  • Loading branch information
benedeki committed Jun 23, 2024
commit 3f632f868facba40c695309bbbdb88f9b0f5fe6b
5 changes: 1 addition & 4 deletions .github/workflows/test_filenames_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ jobs:
name-patterns: '*UnitTests.*,*IntegrationTests.*'
paths: '**/src/test/scala/**'
report-format: 'console'
excludes: |
'server/src/test/scala/za/co/absa/atum/server/api/TestData.scala',
'server/src/test/scala/za/co/absa/atum/server/api/TestTransactorProvider.scala',
'server/src/test/scala/za/co/absa/atum/server/ConfigProviderTest.scala'
excludes: 'server/src/test/scala/za/co/absa/atum/server/api/TestData.scala,server/src/test/scala/za/co/absa/atum/server/api/TestTransactorProvider.scala,server/src/test/scala/za/co/absa/atum/server/ConfigProviderTest.scala'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possiblE to add multi-line exclusions instead of 1 line? Also, is it possible to regexp it? Or at least use wildcard(s)?

Copy link
Collaborator

@miroslavpojer miroslavpojer Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For multi-line exclusion, see and use filename-inspector branch feature/fix-to-use-correct-syntax in your yaml.

  • See updated README.md for an example.

Regex

  • paths support glob patterns (supports **)
  • name-patterns and excludes support fnmatch pattern (do not support **)

Feel free to help with PR review on named branch and its PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think wildcards are possible. RegExpt no, at least not yet now (it hasn't been released yet even).
I actually thought to move the classes into own directories, to make the exclusions simpler. But in its own PR.

Copy link
Collaborator

@miroslavpojer miroslavpojer Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add wildcards, here is my testing example:

- name: Test filename-inspector check
  id: test-file-suffix
  uses: AbsaOSS/filename-inspector@feature/fix-to-use-correct-syntax
  with:
    name-patterns: |
      *GUI*,
      *Unit*
    paths: |
      **/src/test/java/**,
      **/src/test/scala/**
    excludes: |
      *1UnitTest.*,
      *thServiceTest.*
    report-format: 'csv'
    verbose-logging: 'true'
    fail-on-violation: 'true'

See link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multiline example doesn't seem to work. 😠 Reverting to single line, that worked.
(Tried all kind of formats)

verbose-logging: 'false'
fail-on-violation: 'true'
Loading