-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#211: Release notes entry enforcement #212
Merged
benedeki
merged 32 commits into
master
from
feature/211-release-notes-entry-enforcement
Jun 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
e77987e
#211: Release notes entry enforcement
benedeki 0b2b7d1
Merge branch 'master' into feature/211-release-notes-entry-enforcement
lsulak 6e0afae
* added on-issue-comment trigger
benedeki 6688ff6
* testing
benedeki ac2ed7a
* experimenting with on-issue-comment
benedeki 8935beb
* further experimenting
benedeki 1ade8a4
* test X
benedeki 19a773c
* test XI
benedeki e1b0775
* test XII
benedeki f92d564
* test XII
benedeki 7b83c24
* Test XIII
benedeki ac0738e
Update .github/workflows/release_draft.yml
benedeki 829b97c
Merge branch 'master' into feature/211-release-notes-entry-enforcement
benedeki 8b3e36d
* Experiment XIV
benedeki d65f890
Merge branch 'feature/211-release-notes-entry-enforcement' of https:/…
benedeki f2a700c
* Experiment XV
benedeki 615359a
* Experiment XVI
benedeki 58b8b56
* added test filenames check action
benedeki bdaec35
Merge branch 'master' into feature/211-release-notes-entry-enforcement
benedeki b7ca0b7
* fixes
benedeki d41d26c
Merge branch 'feature/211-release-notes-entry-enforcement' of https:/…
benedeki 50be6b2
Apply suggestions from code review
benedeki d40d31e
* removed demo code
benedeki 157deaa
* Fixes
benedeki ea02daa
* Fixed filename patterns
benedeki d00bd4d
* added excludes
benedeki ab081b5
* better alignment
benedeki 4893740
* Typo fix
benedeki b921521
* still wrong
benedeki 7592de1
* multi-line needs different style
benedeki 883cf28
* last try
benedeki 3f632f8
* back to one line excludes
benedeki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
* back to one line excludes
- Loading branch information
commit 3f632f868facba40c695309bbbdb88f9b0f5fe6b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possiblE to add multi-line exclusions instead of 1 line? Also, is it possible to regexp it? Or at least use wildcard(s)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For multi-line exclusion, see and use filename-inspector branch
feature/fix-to-use-correct-syntax
in your yaml.Regex
Feel free to help with PR review on named branch and its PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think wildcards are possible. RegExpt no, at least not yet now (it hasn't been released yet even).
I actually thought to move the classes into own directories, to make the exclusions simpler. But in its own PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add wildcards, here is my testing example:
See link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The multiline example doesn't seem to work. 😠 Reverting to single line, that worked.
(Tried all kind of formats)