Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

219: Suggestion - Doobie multiple results with aggregated status #236

Conversation

benedeki
Copy link
Contributor

@benedeki benedeki commented Aug 3, 2024

Just a suggestion, but it seems to work. Even added a unit test passing before the change and after it too.

…ithAggStatus

# Conflicts:
#	project/Dependencies.scala
#	server/src/test/scala/za/co/absa/atum/server/api/controller/CheckpointControllerUnitTests.scala
Copy link

github-actions bot commented Aug 3, 2024

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 81.38% 🍏
Files changed 100% 🍏

File Coverage
package.scala 100% 🍏

Copy link

github-actions bot commented Aug 3, 2024

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 85.84% 🍏

There is no coverage information present for the Files changed

Copy link

github-actions bot commented Aug 3, 2024

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 82.23% -30.85% 🍏
Files changed 83.04% 🍏

File Coverage
Flows.scala 100% 🍏
PostgresDatabaseProvider.scala 100% 🍏
Runs.scala 100% 🍏
FlowRepositoryImpl.scala 100% 🍏
PartitioningRepositoryImpl.scala 100% 🍏
CheckpointRepositoryImpl.scala 100% 🍏
MeasureFromDB.scala 100% -1318.18%
AdditionalDataFromDB.scala 100% -1318.18%
CheckpointServiceImpl.scala 100% 🍏
PartitioningServiceImpl.scala 100% 🍏
BaseService.scala 100% 🍏
BaseController.scala 100% 🍏
BaseRepository.scala 91.67% -8.33% 🍏
PartitioningControllerImpl.scala 88.89% 🍏
CheckpointFromDB.scala 86.26% -4.58% 🍏
WriteCheckpoint.scala 83.55% -20.42% 🍏
GetPartitioningAdditionalData.scala 81.42% -23.5% 🍏
GetPartitioningMeasures.scala 81.01% -27.37% 🍏
GetFlowCheckpoints.scala 79.96% -29.4% 🍏
GetPartitioningCheckpoints.scala 79.96% -29.4% 🍏
CheckpointControllerImpl.scala 76% 🍏
CreatePartitioningIfNotExists.scala 69.04% -38.43% 🍏
CreateOrUpdateAdditionalData.scala 69.04% -38.43% 🍏

@benedeki benedeki closed this Aug 3, 2024
@benedeki benedeki deleted the feature/219-suggestion-doobie-multiple-results-with-aggregated-status branch August 15, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants