Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#56: Add common project workflows #62

Merged
merged 2 commits into from
Jul 26, 2023
Merged

#56: Add common project workflows #62

merged 2 commits into from
Jul 26, 2023

Conversation

benedeki
Copy link
Contributor

  • Added license_check.yml
  • Added dependent_items.yml
  • Renamed assign_project_to_issue.yml to assign_issue_to_project.yml
  • Added codeowners

Closes #56

@benedeki
#56: Add common project workflows
4c8b518 
* Added license_check.yml
* Added dependent_items.yml
* Renamed assign_project_to_issue.yml to assign_issue_to_project.yml
* Added codeowners
@benedeki benedeki self-assigned this Jul 19, 2023
miroslavpojer
miroslavpojer reviewed Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • built
  • tests run - Test cannot be launched - required fix in related Issues
  • code reviewed

.github/workflows/license_check.yml Outdated Show resolved Hide resolved
@miroslavpojer
Copy link
Collaborator

A command sbt test from root location does not run any test from project modules.
A command sbt test from {root}/agent location leads to 25 errors.
A command sbt test from {root}/agent location leads to 100 errors.

Did I miss some specific way how to run tests? In Read me files there is not useful information about this topic.

@miroslavpojer
Copy link
Collaborator

I am missing workflow for jacoco code measuring.

@benedeki
Copy link
Contributor Author

A command sbt test from root location does not run any test from project modules. A command sbt test from {root}/agent location leads to 25 errors. A command sbt test from {root}/agent location leads to 100 errors.

Did I miss some specific way how to run tests? In Read me files there is not useful information about this topic.

I am missing workflow for jacoco code measuring.

Those to come in subsequent PRs. Originally planned to be all in one, but as it has its own complication it's planned for #64

@benedeki benedeki merged commit c0cdbfc into master Jul 26, 2023
@lsulak lsulak deleted the feature/56-add-common-project-workflows branch August 2, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miroslavpojer miroslavpojer miroslavpojer approved these changes

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@TebaleloS TebaleloS Awaiting requested review from TebaleloS

Assignees

@benedeki benedeki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add common project workflows
2 participants
@benedeki @miroslavpojer