Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2195: S3A and S3N path are not correctly handled #2196

Merged

Conversation

benedeki
Copy link
Collaborator

@benedeki benedeki commented Oct 18, 2023

  • changed to preserve the protocol
  • added UT

Closes #2195

* changed to preserve the protocol
* added UT
@benedeki benedeki requested a review from dk1844 as a code owner October 18, 2023 14:23
@benedeki benedeki added the work in progress Work on this item is not yet finished (mainly intended for PRs) label Oct 18, 2023
@benedeki benedeki requested a review from lsulak October 18, 2023 14:23
lsulak and others added 3 commits October 18, 2023 16:28
… Mac) and commenting out currently failing tests (failing on my machine at least - probably due to dependency problems)
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@benedeki benedeki removed the work in progress Work on this item is not yet finished (mainly intended for PRs) label Dec 8, 2023
Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@benedeki benedeki added the PR:tested Only for PR - PR was tested by a tester (person) label Dec 8, 2023
@benedeki benedeki merged commit ced78c5 into support/2.27 Dec 8, 2023
6 of 8 checks passed
@benedeki benedeki deleted the bugfix/2195-s3a-and-s3n-path-are-not-correctly-handled branch December 8, 2023 16:39
@benedeki benedeki restored the bugfix/2195-s3a-and-s3n-path-are-not-correctly-handled branch December 8, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:tested Only for PR - PR was tested by a tester (person)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants