Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2195 Add s3a wrapper around run scripts #2198

Merged
merged 16 commits into from
Dec 8, 2023

Conversation

Zejnilovic
Copy link
Contributor

@Zejnilovic Zejnilovic commented Nov 7, 2023

A wrapper for any of the run scripts. Just prepend the run command with ./s3a_wrapper.sh and execute as you usually would.

If you want to add jceks file through --conf spark.hadoop.fs.s3a.bucket.SOME_NAME=jceks:/path/to/file.jceks \

benedeki and others added 5 commits October 18, 2023 15:11
* changed to preserve the protocol
* added UT
… Mac) and commenting out currently failing tests (failing on my machine at least - probably due to dependency problems)
Copy link
Contributor

@dk1844 dk1844 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps requirements to run the script could be mentioned somewhere: curl, jq,

scripts/bash/s3a_wrapper.sh Outdated Show resolved Hide resolved
scripts/bash/s3a_wrapper.sh Outdated Show resolved Hide resolved
scripts/bash/enceladus_env.template.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • code review
  • tests

scripts/bash/s3a_wrapper.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When started script now action done. No hint provided.
There should be some hint how to used (place) script.

Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documented outputs from review testing.

scripts/bash/s3a_wrapper.sh Outdated Show resolved Hide resolved
@Zejnilovic Zejnilovic force-pushed the bugfix/2195-add-s3a-wrapper-script branch 2 times, most recently from cc2eab9 to 41247ae Compare November 15, 2023 08:35
scripts/bash/s3a_wrapper.sh Outdated Show resolved Hide resolved
dk1844
dk1844 previously approved these changes Nov 15, 2023
@miroslavpojer miroslavpojer added the PR:tested Only for PR - PR was tested by a tester (person) label Nov 15, 2023
miroslavpojer
miroslavpojer previously approved these changes Nov 15, 2023
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pull
  • code review
  • manual test

@benedeki benedeki changed the base branch from bugfix/2195-s3a-and-s3n-path-are-not-correctly-handled to support/2.27 December 8, 2023 16:14
@benedeki benedeki dismissed stale reviews from miroslavpojer and dk1844 December 8, 2023 16:14

The base branch was changed.

Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Zejnilovic Zejnilovic merged commit ba44460 into support/2.27 Dec 8, 2023
5 of 6 checks passed
@Zejnilovic Zejnilovic deleted the bugfix/2195-add-s3a-wrapper-script branch December 8, 2023 16:47
@Zejnilovic Zejnilovic restored the bugfix/2195-add-s3a-wrapper-script branch December 8, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:tested Only for PR - PR was tested by a tester (person)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants