-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2195 Add s3a wrapper around run scripts #2198
Conversation
* changed to preserve the protocol * added UT
… Mac) and commenting out currently failing tests (failing on my machine at least - probably due to dependency problems)
…-correctly-handled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps requirements to run the script could be mentioned somewhere: curl, jq,
Co-authored-by: Daniel K <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pulled
- code review
- tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When started script now action done. No hint provided.
There should be some hint how to used (place) script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented outputs from review testing.
cc2eab9
to
41247ae
Compare
Co-authored-by: Daniel K <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pull
- code review
- manual test
The base branch was changed.
Kudos, SonarCloud Quality Gate passed! |
A wrapper for any of the run scripts. Just prepend the run command with
./s3a_wrapper.sh
and execute as you usually would.If you want to add jceks file through
--conf spark.hadoop.fs.s3a.bucket.SOME_NAME=jceks:/path/to/file.jceks \