Feature/#2219 enceladus to run with new supported version of mongo db #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benedeki
approved these changes
Dec 17, 2024
…new-supported-version-of-MongoDB
|
|
benedeki
added
the
PR:no testing needed
|
Merging on behalf of @ABMC831 who is away for longer period of time. |
benedeki
deleted the
feature/#2219-Enceladus-to-run-with-new-supported-version-of-MongoDB
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed deprecation from build failures - otherwise cannot build it with tools that actually respect it
Changed embeded mongo provider for unit test with recent one (capable of hosting older versions as well for backwards compatibility)
-> and set it to v 8.0
Added specific unit test checking behavior of mongo, relevant to its version being after 4.4 or prior to 4.2
changed unit tests influenced by this behavior.....
the "functionality" is only available since 4.4 and in older version, it is kinda ignored....
seems like the original code is written as if expecting the functionality being there... while unit tests are testing it being ignored
This obviously expects deployment mongo to be of version 8.0
apart from this discrepancy.... runnin unit tests, integration tests and initial manual testing of menas seems to work in either, legacy mongo 4.0 as well as mongo 8.0 (just Mongo updates needs to be done in succession on the existing database)