-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to composite action. Improving API calls usage. #44
Merged
miroslavpojer
merged 187 commits into
master
from
feature/43-Migration-to-composite-GH-Action-and-facing-rate-limits
Aug 1, 2024
Merged
Changes from 1 commit
Commits
Show all changes
187 commits
Select commit
Hold shift + click to select a range
d5ff767
- Finished migration of GH action control logic to composite action t…
miroslavpojer 3d528bf
Delete local_run.sh
miroslavpojer 3be9adb
- Backup of current state.
miroslavpojer e78a22a
- Backup of current state.
miroslavpojer 1f66d91
- Adding labels to PR class.
miroslavpojer cde7f77
- Changes from CI testing.
miroslavpojer e700343
- Changes from CI testing.
miroslavpojer 68ef3ad
- Changes from CI testing.
miroslavpojer 5a4aaef
- Changes from CI testing.
miroslavpojer b32fa82
- Changes from CI testing.
miroslavpojer 73202fd
- Changes from CI testing.
miroslavpojer 2555a67
- Changes from CI testing.
miroslavpojer facf59c
- Changes from CI testing.
miroslavpojer 77c0eaa
- Changes from CI testing.
miroslavpojer b923c4f
- Changes from CI testing.
miroslavpojer bbb397a
- Changes from CI testing.
miroslavpojer f8dc282
- Changes from CI testing.
miroslavpojer bb2191f
- Changes from CI testing.
miroslavpojer a596aeb
- Changes from CI testing.
miroslavpojer 6405596
- Changes from CI testing.
miroslavpojer 5f55f96
- Changes from CI testing.
miroslavpojer dfad570
- Changes from CI testing.
miroslavpojer 4a37700
- Changes from CI testing.
miroslavpojer aef1e54
- Changes from CI testing.
miroslavpojer bfed84f
- Changes from CI testing.
miroslavpojer aa94fb5
- Changes from CI testing.
miroslavpojer 00baec4
- Changes from CI testing.
miroslavpojer 0cbca8b
- Changes from CI testing.
miroslavpojer 6e77ccb
- Changes from CI testing.
miroslavpojer 3a6ebdc
- Changes from CI testing.
miroslavpojer 0b1a74c
- Changes from CI testing.
miroslavpojer 88cde8b
- Changes from CI testing.
miroslavpojer afac9f5
- Changes from CI testing.
miroslavpojer 6ccfe5f
- Changes from CI testing.
miroslavpojer 1bb0e64
- Changes from CI testing.
miroslavpojer db18074
- Changes from CI testing.
miroslavpojer 4b5af5a
- Changes from CI testing.
miroslavpojer 021286e
- Changes from CI testing.
miroslavpojer ac3815b
- Changes from CI testing.
miroslavpojer 23a233d
- Changes from CI testing.
miroslavpojer e4d3678
- Changes from CI testing.
miroslavpojer d5f3dfb
- Fixed problems on CI env.
miroslavpojer 642dfe0
- Fixed unit tests.
miroslavpojer 6bd872a
- Removed chapters_json and replace by logic to hold chapters and the…
miroslavpojer fce5814
- Implemented three test for release_notes_builder.build() method. Fo…
miroslavpojer e24d0e8
- Implemented logic for generation of release notes rows. Each row re…
miroslavpojer 6cceb8e
- Added test data to print labeled PRs without issue.
miroslavpojer 32e4a2b
- Added test data with issue and multiple PR with RLS notes.
miroslavpojer 3d4000f
- Review and fixes of logic release_notes_builder.py. Covered custom …
miroslavpojer b40fb98
- Several code improvements and logical error fixes.
miroslavpojer 1b9579c
- Implemented full rls notes body content.
miroslavpojer 9204329
- Improve logging messages for getting latest release.
miroslavpojer fcd817c
- Fixed error messages - remove None owner.
miroslavpojer 91349f0
- Debugging record creation process.
miroslavpojer 8db5e57
- Debugging record creation process.
miroslavpojer 849c574
- Adding logic for creation of record when PR does not have Issue def…
miroslavpojer e654f48
- Fixed unit tests.
miroslavpojer 2e149e7
- Improved format of PR line in RLS notes.
miroslavpojer b54d0bd
- Add logic for adding PR links to title of RLS note row.
miroslavpojer bcc0eb6
- Add debug message for analyze data from real usage.
miroslavpojer 6511fc9
- Add support for PR labels loading.
miroslavpojer 12c351e
- Real data debug changes.
miroslavpojer f81376d
- Real data debug changes.
miroslavpojer b4719be
- Fix issue.
miroslavpojer 935624d
- Fix issue.
miroslavpojer 6eb1cde
- Fix issue.
miroslavpojer 597507b
- Fix issue.
miroslavpojer 244bc03
- Fix issue.
miroslavpojer 57a49bc
- Fix issue.
miroslavpojer ee78169
- Fix issue.
miroslavpojer a758daf
- Added mining of commits.
miroslavpojer b2c6b35
- Experiments.
miroslavpojer cfc1734
- Experiments.
miroslavpojer 928c5fb
- Experiments.
miroslavpojer 092aee2
- Experiments.
miroslavpojer 6b5f761
- Experiments.
miroslavpojer c67faf7
- Experiments.
miroslavpojer e8018a0
- Experiments.
miroslavpojer 0d6a024
- Experiments.
miroslavpojer d8a0d4c
- Experiments.
miroslavpojer ed15b1f
- Experiments.
miroslavpojer e2876d3
- Add doc string to all classes and methods.
miroslavpojer 25b67ac
- Moved GH API method calls from script like file to GithubManager si…
miroslavpojer 4651596
- Review of TODOs. Added correct texts to them.
miroslavpojer f371a49
- Debugging.
miroslavpojer 780398c
- Debugging.
miroslavpojer b1ab99b
- Debugging.
miroslavpojer 5569c90
- Debugging.
miroslavpojer b910009
- Remove prints for debug.
miroslavpojer 4705b8d
- Debugging after refactoring.
miroslavpojer 395f947
- Fix decision about is merged or is closed for PR>
miroslavpojer 0736ccf
- Add correct detection of issue mentions in first pr.
miroslavpojer 864f519
- Fix error.
miroslavpojer ecc1fea
- Add logic to skip open issues.
miroslavpojer a6c0c93
- Improve the condition for No topic chapter.
miroslavpojer 62be5ce
- Improved unit tests for release_notes_builder.py.
miroslavpojer b4bf2e7
- Improved unit tests for release_notes_builder.py.
miroslavpojer e10094a
- Finished logical test coverage of possible input for release notes …
miroslavpojer 8cca110
- Improved unit tests for release notes builder to prepare full_name …
miroslavpojer f68742d
- Addressing review note. Simplification of the code.
miroslavpojer 510b0c7
- Addressing review note. Finished OOP design for main script.
miroslavpojer a403ed6
- Addressing review note.
miroslavpojer a46aa1f
- Addressing review note.
miroslavpojer b5dba34
- Addressing review note.
miroslavpojer 201f22b
- Implemented unit tests for class github_manager.py.
miroslavpojer 976bab7
- Implemented all planned unit tests.
miroslavpojer 118b1da
- Debugging missing issue in output.
miroslavpojer 3521c70
- Improving filtration logic.
miroslavpojer 0d1d73d
- Improving filtration logic.
miroslavpojer c4a7237
- Add missing build CI yml file.
miroslavpojer 7e598b8
- Fixing python install problems.
miroslavpojer a4d3c8c
- Remove code coverage.
miroslavpojer dd71707
- Remove code coverage.
miroslavpojer 3fd991d
- Testing fix.
miroslavpojer 91dc492
- Return code coverage and experiment with code coverage limits.
miroslavpojer a54b806
- Fix error.
miroslavpojer c78a893
- Debugging.
miroslavpojer f114228
- Debugging.
miroslavpojer be59f0e
- Debugging.
miroslavpojer 4d738bc
- Debugging.
miroslavpojer 2d7af9c
- Debugging.
miroslavpojer b4feb24
- Debugging.
miroslavpojer e6c5ed0
- Final version of initial code coverage limits.
miroslavpojer 245b9d3
- Fix.
miroslavpojer a7366de
- Code improvements.
miroslavpojer 29222e2
- Improve the since logic for no release exist.
miroslavpojer 6fe7c9b
- Commit of changes before reload IDE.
miroslavpojer 11f6d62
Revert "- Commit of changes before reload IDE."
miroslavpojer b735de2
- Replaced logic from stand alone package wrapping pyGithub to utils …
miroslavpojer 61b302e
- Logic reworded to support changes after decorator based solution in…
miroslavpojer 27c5e83
- Experiments.
miroslavpojer fc5cb26
- Try to fix wrong method name in debug logs.
miroslavpojer 190b525
- Fix code problem after decorators introduction.
miroslavpojer 8952927
Developed most from planned unit tests. Missing two files to fully co…
miroslavpojer 63cf6e9
Implemented new set of unit tests.
miroslavpojer 91e061e
Implemented new set of unit tests.
miroslavpojer 70b0eef
Update of README.md after code refactoring.
miroslavpojer 2c18dc5
- Refactoring project src files structure to follow pythonic project …
miroslavpojer 6f43877
Experiments with build.yml.
miroslavpojer 82cb4da
Experiments with build.yml.
miroslavpojer 304a0d3
Experiments with build.yml.
miroslavpojer 6014c36
Experiments with build.yml.
miroslavpojer b59dfe1
Experiments with build.yml.
miroslavpojer b3b2a90
Experiments with build.yml.
miroslavpojer ad02e7c
Experiments with build.yml.
miroslavpojer 4e04b28
Experiments with action.yml.
miroslavpojer e89ce1d
Experiments with action.yml.
miroslavpojer 5db580b
Fixed problem with naming conflict.
miroslavpojer d9adbef
Fix action.yml.
miroslavpojer c719955
Fix action.yml.
miroslavpojer f7d8f48
Experiment action.yml.
miroslavpojer bfaa036
Experiment action.yml.
miroslavpojer 1dc84db
Experiment action.yml.
miroslavpojer 6a80b61
Experiment action.yml.
miroslavpojer bbe6ffa
Experiment action.yml.
miroslavpojer 0d0f48f
Experiment action.yml.
miroslavpojer c661255
Experiment setup.py.
miroslavpojer 69e5433
Experiment with root py file.
miroslavpojer 5a84b4d
Experiments with fix of CI action run.
miroslavpojer aad08d0
Added missing test to reach coverage.
miroslavpojer 76daba4
Update README.md to mention main.py with correct path to it.
miroslavpojer b0418a4
Remove debug echos.
miroslavpojer 0f30788
Small fixes.
miroslavpojer 61a5cf8
- Added correct .gitignore file content valid for python project.
miroslavpojer 2510483
- Fixes and suggestions from Review comments.
miroslavpojer 58756d1
- Addressed review note.
miroslavpojer fb6efb1
- Merge install of python project's requirements into python setup ac…
miroslavpojer 16e5a01
- Testing.
miroslavpojer cc8841f
- Testing.
miroslavpojer eea5d67
- Testing.
miroslavpojer c4df40c
- Testing.
miroslavpojer 244ea63
- Testing.
miroslavpojer dd518c1
- Testing.
miroslavpojer 17cc33a
- Testing.
miroslavpojer 710775c
- Testing.
miroslavpojer 38b1013
- Testing.
miroslavpojer 8b7b41f
- Testing.
miroslavpojer 71cbcc7
- Testing.
miroslavpojer 60969c4
- Testing.
miroslavpojer de20ffe
- Add missing python setup.
miroslavpojer 40299d5
- Introduced default value for run step shell.
miroslavpojer 9634a6d
- Introduced default value for run step shell.
miroslavpojer 1d2d0ca
- Added check for minimal required version of python.
miroslavpojer 44db9ac
- Return back shell definition as default setting is not supported in…
miroslavpojer f6fbe03
- Defined minimal version 3.10 for Python.
miroslavpojer 34c0851
- Remove shell definition.
miroslavpojer 2790d1d
- Return back shell definition.
miroslavpojer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,159 @@ | ||
.idea | ||
# Byte-compiled / optimized / DLL files | ||
__pycache__/ | ||
*.py[cod] | ||
*$py.class | ||
|
||
# C extensions | ||
*.so | ||
|
||
# Distribution / packaging | ||
.Python | ||
build/ | ||
develop-eggs/ | ||
downloads/ | ||
eggs/ | ||
.eggs/ | ||
lib/ | ||
lib64/ | ||
parts/ | ||
sdist/ | ||
var/ | ||
wheels/ | ||
share/python-wheels/ | ||
*.egg-info/ | ||
.installed.cfg | ||
*.egg | ||
MANIFEST | ||
|
||
# PyInstaller | ||
# Usually these files are written by a python script from a template | ||
# before PyInstaller builds the exe, so as to inject date/other infos into it. | ||
*.manifest | ||
*.spec | ||
|
||
# Installer logs | ||
pip-log.txt | ||
pip-delete-this-directory.txt | ||
|
||
# Unit test / coverage reports | ||
htmlcov/ | ||
.tox/ | ||
.nox/ | ||
.coverage | ||
.coverage.* | ||
.cache | ||
nosetests.xml | ||
coverage.xml | ||
*.cover | ||
*.py,cover | ||
.hypothesis/ | ||
.pytest_cache/ | ||
cover/ | ||
|
||
# Translations | ||
*.mo | ||
*.pot | ||
|
||
# Django stuff: | ||
*.log | ||
local_settings.py | ||
db.sqlite3 | ||
db.sqlite3-journal | ||
|
||
# Flask stuff: | ||
instance/ | ||
.webassets-cache | ||
|
||
# Scrapy stuff: | ||
.scrapy | ||
|
||
# Sphinx documentation | ||
docs/_build/ | ||
|
||
# PyBuilder | ||
.pybuilder/ | ||
target/ | ||
node_modules | ||
/local_run.sh | ||
/.coverage | ||
|
||
# Jupyter Notebook | ||
.ipynb_checkpoints | ||
|
||
# IPython | ||
profile_default/ | ||
ipython_config.py | ||
|
||
# pyenv | ||
# For a library or package, you might want to ignore these files since the code is | ||
# intended to run in multiple environments; otherwise, check them in: | ||
# .python-version | ||
|
||
# pipenv | ||
# According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control. | ||
# However, in case of collaboration, if having platform-specific dependencies or dependencies | ||
# having no cross-platform support, pipenv may install dependencies that don't work, or not | ||
# install all needed dependencies. | ||
#Pipfile.lock | ||
|
||
# poetry | ||
# Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control. | ||
# This is especially recommended for binary packages to ensure reproducibility, and is more | ||
# commonly ignored for libraries. | ||
# https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control | ||
#poetry.lock | ||
|
||
# pdm | ||
# Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control. | ||
#pdm.lock | ||
# pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it | ||
# in version control. | ||
# https://pdm.fming.dev/#use-with-ide | ||
.pdm.toml | ||
|
||
# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm | ||
__pypackages__/ | ||
|
||
# Celery stuff | ||
celerybeat-schedule | ||
celerybeat.pid | ||
|
||
# SageMath parsed files | ||
*.sage.py | ||
|
||
# Environments | ||
.env | ||
.venv | ||
env/ | ||
venv/ | ||
ENV/ | ||
env.bak/ | ||
venv.bak/ | ||
|
||
# Spyder project settings | ||
.spyderproject | ||
.spyproject | ||
|
||
# Rope project settings | ||
.ropeproject | ||
|
||
# mkdocs documentation | ||
/site | ||
|
||
# mypy | ||
.mypy_cache/ | ||
.dmypy.json | ||
dmypy.json | ||
|
||
# Pyre type checker | ||
.pyre/ | ||
|
||
# pytype static type analyzer | ||
.pytype/ | ||
|
||
# Cython debug symbols | ||
cython_debug/ | ||
|
||
# PyCharm | ||
# JetBrains specific template is maintained in a separate JetBrains.gitignore that can | ||
# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore | ||
# and can be added to the global gitignore or merged into this file. For a more nuclear | ||
# option (not recommended) you can uncomment the following to ignore the entire idea folder. | ||
.idea/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,14 +43,13 @@ branding: | |
runs: | ||
using: 'composite' | ||
steps: | ||
- uses: actions/[email protected] | ||
with: | ||
python-version: '3.11' | ||
|
||
- name: Install Python dependencies | ||
run: | | ||
python3 -m pip install --upgrade pip | ||
python3 -m pip install -r ${{ github.action_path }}/requirements.txt | ||
shell: bash | ||
|
||
- name: Call command python3 | ||
run: python3 --version | ||
python -m pip install -r ${{ github.action_path }}/requirements.txt | ||
miroslavpojer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
shell: bash | ||
|
||
- name: Set PROJECT_ROOT and update PYTHONPATH | ||
|
@@ -71,9 +70,8 @@ runs: | |
INPUT_PRINT_EMPTY_CHAPTERS: ${{ inputs.print-empty-chapters }} | ||
INPUT_CHAPTERS_TO_PR_WITHOUT_ISSUE: ${{ inputs.chapters-to-pr-without-issue }} | ||
INPUT_VERBOSE: ${{ inputs.verbose }} | ||
|
||
INPUT_GITHUB_REPOSITORY: ${{ github.repository }} | ||
|
||
run: | | ||
python3 ${{ github.action_path }}/main.py | ||
python ${{ github.action_path }}/main.py | ||
shell: bash | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should not define default shell. Let it for the user There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, but 'shell' parameter is required in action.yml. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget the caching mechanism - https://github.com/actions/setup-python?tab=readme-ov-file#caching-packages-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still no
pip
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did several experiments with that.