RLG-3595 rialto v2 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwfchu
reviewed
Aug 30, 2024
| #### Override list element | ||
| You can refer to list elements by their index (starting with 0) | ||
| ```python | ||
| overrides={"runner.mail.to[1]": "[email protected]"} |
There was a problem hiding this comment.
maybe confusing to say start at 0 but use 1 as the example :P also do you REALLY need to state starting index?
| ### PysparkFeatureLoader | ||
|
|
||
| This class needs to be instantiated with an active spark session, data loader and a path to the metadata schema (in the format of "catalog_name.schema_name"). | ||
|
|
||
| ```python | ||
| from rialto.loader import PysparkFeatureLoader | ||
|
|
||
| feature_loader = PysparkFeatureLoader(spark= spark_instance, data_loader= data_loader_instance, metadata_schema= "catalog.schema") | ||
| feature_loader = PysparkFeatureLoader(spark= spark_instance, feature_schema="catalog.schema", metadata_schema= "catalog.schema2", date_column="information_date") |
There was a problem hiding this comment.
looks like you removed the databricks reference explicitly to something more generic, but you carrying the concept of catalog, which is databricks specific
There was a problem hiding this comment.
obviously this carries through to the rest of the changes too
ie you reference pysparkfeature loader and not toegther with DatabricksLoader anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.