Skip to content
This repository has been archived by the owner on Aug 3, 2021. It is now read-only.

Added typescript definitions #26

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

emberist
Copy link

@emberist emberist commented Nov 11, 2020

Just to avoid @ts-ignore in typescript project

jakubkoci and others added 29 commits January 27, 2020 14:05
Ignoring it globally causes android src to be excluded
from the packed tarball

Signed-off-by: Gaurav Narula <[email protected]>
npmignore: ignore src only in project root
Signed-off-by: Jakub Koci <[email protected]>
* Store pool and wallet handles in maps

Makes the API compatible with libindy nodejs wrapper

* Update exported methods to use walletHandle and buffers

iOS native calls remain untested

* android: Update module name
* crypto: fix return types

Signed-off-by: Gaurav Narula <[email protected]>
Signed-off-by: Gaurav Narula <[email protected]>
Signed-off-by: Gaurav Narula <[email protected]>
Rename IndyBridge to IndySdk (#10)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Added implementation of buildGetAttribRequest, buildGetNymRequest and
parseGetNymResponse

Signed-off-by: Gaurav Narula <[email protected]>
@TimoGlastra
Copy link
Contributor

Hi @riccardocaranfil! We're working on getting the types published to the DefinitelyTyped repo.

Because indy-sdk and rn-indy-sdk share the same type definitions, we would have to maintain two versions of the definition if we add them to the repo.

See https://github.com/TimoGlastra/DefinitelyTyped/blob/%40types/indy-sdk/types/indy-sdk/index.d.ts for the current working version. It does seem like your definition contains some types not in our version and vice versa, so it'll be good to combine them.

See openwallet-foundation/credo-ts#38 for more informatin

@emberist
Copy link
Author

@TimoGlastra sounds good! Thanks!

@TimoGlastra
Copy link
Contributor

@riccardocaranfil I finally got around to creating a PR in the definitely typed repo. See https://www.npmjs.com/package/@types/indy-sdk for the published package.

You can use it for rn-indy-sdk using package aliases:

# npm
npm install @types/rn-indy-sdk@npm:@types/indy-sdk

# yarn
yarn add @types/rn-indy-sdk@npm:@types/indy-sdk

Or adding it to your package.json like this:

{
    //...
   "devDependencies": {
        "@types/rn-indy-sdk": "npm:@types/indy-sdk"
    }
}

I see your PR contains types that are not in the repo yet. I'd like to also get them included in the @types/indy-sdk package. Would you like to add it yourself? Otherwise I can look into porting it

See https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/indy-sdk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants