#65 Fix default record id prefix being null #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'd just suggest to add a regression test that fails with the old code and succeeds with the new code. Cause right now it is not obvious that the fix works. |
JaCoCo code coverage report - scala 2.12.12
|
Should be fixed now. |
kevinwallimann
changed the title
Zejnilovic
dismissed stale reviews from kevinwallimann and yruslan
via
46d484a
yruslan
previously approved these changes
Oct 24, 2024
benedeki
reviewed
Oct 29, 2024
| val reportDateFormat = "yyyy-MM-dd" | ||
| val infoVersionColumn = prefix + "_info_version" | ||
| val recordId = prefix + "_record_id" | ||
|
|
There was a problem hiding this comment.
I would change all the val to def, as it's customary for traits (def can be overridden by a val or def, val can be overridden by val only).
Or at least those, that are abstract. To avoid potential similar problems, to the one this PR fixes.
benedeki
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65
Changed to
defs so we don't have a race condition on init of thevals.