Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Token Factory integration #11

Draft
wants to merge 8 commits into
base: official-ibc-fork
Choose a base branch
from

Conversation

Kayanski
Copy link

@Kayanski Kayanski commented Jan 7, 2025

This PR adds token factory capabilites into cw-multi-test.
For now the 3 following messages are handled for Osmosis :
MsgCreateDenom
MsgMint
MsgBurn

TODO :
Implement queries (is it needed ?)
Implement other tokenfactory flavors (neutron and xion have the same flavor)

@Kayanski Kayanski marked this pull request as draft January 7, 2025 13:43
@Kayanski Kayanski requested a review from Buckram123 January 7, 2025 13:43
@Kayanski Kayanski changed the base branch from main to official-ibc-fork January 8, 2025 15:24
Copy link

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Couldn't find explanation why protobuf types copied instead of using osmosis-std (please add module-level comment)

bail!("Subdenom {subdenom} by sender {sender} doesn't exist")
}

// We mint. No need for transactional cache here, if this fails, the tokenfactory mint fails

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// We mint. No need for transactional cache here, if this fails, the tokenfactory mint fails
// We burn. No need for transactional cache here, if this fails, the tokenfactory burn fails

typo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why not to use osmosis-std?

@Kayanski
Copy link
Author

Kayanski commented Jan 8, 2025

Nice. Couldn't find explanation why protobuf types copied instead of using osmosis-std (please add module-level comment)

I copied, because i don't want to bring osmosis-std here it's soooooo heavy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants