Improve MDL implementation of luminance
#2224
Merged
+8
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: krohmerNV <[email protected]>
krohmerNV
added a commit
to krohmerNV/MaterialX
that referenced
this pull request
Feb 12, 2025
…implementation
krohmerNV
added a commit
to krohmerNV/MaterialX
that referenced
this pull request
Feb 12, 2025
…implementation
Signed-off-by: Jonathan Stone <[email protected]>
jstone-lucasfilm
approved these changes
Feb 15, 2025
jstone-lucasfilm
changed the title
luminance implementation in MDL
jstone-lucasfilm
changed the title
luminance implementation in MDLluminance
jstone-lucasfilm
merged commit cf87592
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the coefficient parameter and changed the implementation to match the other back-ends.