Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚚 Rename safeValues to maskedValues #46

Merged
merged 1 commit into from
Jun 3, 2024
Merged

🚚 Rename safeValues to maskedValues #46

merged 1 commit into from
Jun 3, 2024

Conversation

pavelsvagr
Copy link
Member

PR addresses:

  • Renames safeValues function to maskedValues based on standard way how to name hidden values in configurations / env vars

Fixes #16

@pavelsvagr pavelsvagr requested a review from tbunata June 3, 2024 08:41
@pavelsvagr pavelsvagr self-assigned this Jun 3, 2024
tbunata
tbunata approved these changes Jun 3, 2024
View reviewed changes
Copy link

@tbunata tbunata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelsvagr pavelsvagr merged commit 5e00ffe into master Jun 3, 2024
8 checks passed
@pavelsvagr pavelsvagr deleted the chore/rename-safe-values branch June 3, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbunata tbunata tbunata approved these changes

Assignees

@pavelsvagr pavelsvagr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SafeConfig name is confusing
2 participants
@pavelsvagr @tbunata