Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a switch to the LoRAs in the style dialoge. #1568

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

moonwhaler
Copy link
Contributor

@moonwhaler moonwhaler commented Jan 27, 2025

Added a switch to the LoRA list in the styles / settings dialog to activate/decativate single LoRAs. This makes experiments with different LoRAs or LoRA combinations more streamlined and intuitive.

@moonwhaler
Copy link
Contributor Author

Not sure what the pipline error is exactly...
Screenshot_20250127_220114

@Acly
Copy link
Owner

Acly commented Jan 27, 2025

I believe the change in api.py should not be needed, since disabled Lora aren't added to the workflow input in the first place (filtered out in style). Looks good otherwise

Not sure what the pipline error is exactly...

looks like this for me:
image

basically just run ruff format and it fix the formatting

@moonwhaler
Copy link
Contributor Author

Just did that. Hope it worked.

@Acly
Copy link
Owner

Acly commented Jan 28, 2025

Works.

Please try to remove api.py changes also:

I believe the change in api.py should not be needed, since disabled Lora aren't added to the workflow input in the first place (filtered out in style).

@moonwhaler
Copy link
Contributor Author

Just reverted the changes to api.py - and tested this. You're right. I didn't need the change in that file.

@Acly Acly merged commit a5f8f31 into Acly:main Jan 30, 2025
@moonwhaler moonwhaler deleted the lora-switch branch January 30, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants